Skip to content

HCK-16955: check constraint names #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vitalii4as merged 2 commits into from
Jul 10, 2026
Merged

HCK-16955: check constraint names #261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
657a51b
fix: respect script generation options for quoted/non-quoted identifi…
chulanovskyi-bs Jul 10, 2026
de70241
fix: properly update constraint name
chulanovskyi-bs Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 29 additions & 21 deletions forward_engineering/alterScript/alterScriptHelpers/entityHelpers/checkConstraintHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
const _ = require('lodash');
const { AlterCollectionDto } = require('../../types/AlterCollectionDto');
const { AlterScriptDto, SCRIPT_TYPE } = require('../../types/AlterScriptDto');
const { wrapInQuotes, getSchemaOfAlterCollection, getFullCollectionName } = require('../../../utils/general');
const {
getSchemaOfAlterCollection,
getFullCollectionName,
prepareNameForScriptFormat,
} = require('../../../utils/general');
const { assignTemplates } = require('../../../utils/assignTemplates');
const templates = require('../../../ddlProvider/templates');

Expand Down Expand Up @@ -32,25 +36,33 @@ const dropConstraint = (tableName, constraintName) => {
};

/**
* @param {AlterCollectionDto} collection
* @param {object} params
* @param {AlterCollectionDto} params.collection
* @param {string} params.scriptFormat
* @return {Array<CheckConstraintHistoryEntry>}
* */
const mapCheckConstraintNamesToChangeHistory = collection => {
const mapCheckConstraintNamesToChangeHistory = ({ collection, scriptFormat }) => {
const checkConstraintHistory = collection?.compMod?.chkConstr;
if (!checkConstraintHistory) {
return [];
}

const newConstraints = checkConstraintHistory.new || [];
const oldConstraints = checkConstraintHistory.old || [];

const constrNames = _.chain([...newConstraints, ...oldConstraints])
.map(constr => constr.chkConstrName)
.uniq()
.value();

return constrNames.map(chkConstrName => {
return constrNames.map(rawChkConstrName => {
const chkConstrName = prepareNameForScriptFormat(scriptFormat)(rawChkConstrName);

const updateName = constraint => (constraint ? { ...constraint, chkConstrName } : undefined);

return {
old: _.find(oldConstraints, { chkConstrName }),
new: _.find(newConstraints, { chkConstrName }),
old: updateName(_.find(oldConstraints, { chkConstrName: rawChkConstrName })),
new: updateName(_.find(newConstraints, { chkConstrName: rawChkConstrName })),
};
});
};
Expand All @@ -64,8 +76,7 @@ const getDropCheckConstraintScriptDtos = (constraintHistory, fullTableName) => {
return constraintHistory
.filter(historyEntry => historyEntry.old && !historyEntry.new)
.map(historyEntry => {
const wrappedConstraintName = wrapInQuotes(historyEntry.old.chkConstrName);
const script = dropConstraint(fullTableName, wrappedConstraintName);
const script = dropConstraint(fullTableName, historyEntry.old.chkConstrName);
return AlterScriptDto.getInstance(script, true, true, SCRIPT_TYPE.alterEntity);
});
};
Expand Down Expand Up @@ -99,7 +110,7 @@ const getAddCheckConstraintScriptDtos = (constraintHistory, fullTableName) => {
.filter(historyEntry => historyEntry.new && !historyEntry.old)
.map(historyEntry => {
const { chkConstrName, constrExpression } = historyEntry.new;
const script = addCheckConstraint(fullTableName, wrapInQuotes(chkConstrName), constrExpression);
const script = addCheckConstraint(fullTableName, chkConstrName, constrExpression);
return AlterScriptDto.getInstance(script, true, false, SCRIPT_TYPE.alterEntity);
});
};
Expand All @@ -121,14 +132,10 @@ const getUpdateCheckConstraintScriptDtos = (constraintHistory, fullTableName) =>
})
.flatMap(historyEntry => {
const { chkConstrName: oldConstrainName } = historyEntry.old;
const dropConstraintScript = dropConstraint(fullTableName, wrapInQuotes(oldConstrainName));
const dropConstraintScript = dropConstraint(fullTableName, oldConstrainName);

const { chkConstrName: newConstrainName, constrExpression: newConstraintExpression } = historyEntry.new;
const addConstraintScript = addCheckConstraint(
fullTableName,
wrapInQuotes(newConstrainName),
newConstraintExpression,
);
const addConstraintScript = addCheckConstraint(fullTableName, newConstrainName, newConstraintExpression);

return [
AlterScriptDto.getInstance(dropConstraintScript, true, true, SCRIPT_TYPE.alterEntity),
Expand All @@ -138,20 +145,21 @@ const getUpdateCheckConstraintScriptDtos = (constraintHistory, fullTableName) =>
};

/**
* @param {{ scriptFormat: string }}
* @param {object} params
* @param {string} params.scriptFormat
* @return {(collection: AlterCollectionDto) => Array<AlterScriptDto>}
* */
const getModifyCheckConstraintScriptDtos =
({ scriptFormat }) =>
collection => {
const collectionSchema = getSchemaOfAlterCollection(collection);
const fullName = getFullCollectionName(scriptFormat)(collectionSchema);
const fullTableName = getFullCollectionName(scriptFormat)(collectionSchema);

const constraintHistory = mapCheckConstraintNamesToChangeHistory(collection);
const constraintHistory = mapCheckConstraintNamesToChangeHistory({ collection, scriptFormat });

const addCheckConstraintScripts = getAddCheckConstraintScriptDtos(constraintHistory, fullName);
const dropCheckConstraintScripts = getDropCheckConstraintScriptDtos(constraintHistory, fullName);
const updateCheckConstraintScripts = getUpdateCheckConstraintScriptDtos(constraintHistory, fullName);
const addCheckConstraintScripts = getAddCheckConstraintScriptDtos(constraintHistory, fullTableName);
const dropCheckConstraintScripts = getDropCheckConstraintScriptDtos(constraintHistory, fullTableName);
const updateCheckConstraintScripts = getUpdateCheckConstraintScriptDtos(constraintHistory, fullTableName);

return [...addCheckConstraintScripts, ...dropCheckConstraintScripts, ...updateCheckConstraintScripts];
};
Expand Down
Loading