Bootstrap vcpkg with -disableMetrics instead of touching disable-metrics file - #363
Merged
Conversation
…isable-metrics file Replaces the "Disable vcpkg metrics" step (which just dropped a vcpkg.disable-metrics marker file) with a "Bootstrap vcpkg" step that runs bootstrap-vcpkg.bat/.sh -disableMetrics after updating vcpkg, matching the approach already used in worker/windows/install.ps1. Also fixes two now-stale `ty: ignore` comments in SafeGitHubEventHandler that a newer ty release flags as unused/incorrect, unrelated to the vcpkg change but blocking the pre-commit hook.
uv run --package master only syncs master's own dependency set, which doesn't include ty (a root dev-dependency), so a stale ty binary left in the shared .venv from an earlier sync was never reconciled against the lockfile and silently diverged from the pinned version CI uses. Running `uv sync` first forces the venv to match uv.lock every time. Also reverts the previous commit's `ty: ignore` comment changes, which were based on diagnostics from that stale, unpinned ty version.
ty only type-checks master/master.cfg and master/custom_steps.py, so it belongs to the master package, not the workspace root. This makes `uv run --package master ty check` resolve and pin ty on its own (installing it fresh on a clean checkout), instead of silently relying on whatever ty happens to already be sitting in the shared .venv from an unrelated root-level sync. Simplifies the pre-commit hook and CI workflow back to a single `uv run --package master ...` call, and `ty` stays out of the production Docker image since it's a dev-only dependency (`--no-dev` still excludes it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vcpkg.disable-metricsmarker file) with a "Bootstrap vcpkg" step that runsbootstrap-vcpkg.bat/.sh -disableMetricsafter updating vcpkg, matching the approach already used inworker/windows/install.ps1.ty: ignorecomments inSafeGitHubEventHandlerthat a newertyrelease flags as unused/incorrect. Unrelated to the vcpkg change, but was blocking the pre-commit hook on a clean checkout of master too.Test plan
pre-commit run --files master/master.cfgpasses locally