Bump ty to 0.0.65 and ruff to 0.16.0 - #364
Merged
Merged
Conversation
Updates the pinned versions and fixes what the newer releases flag: ruff's import-sort and RUF059/PLW1508 rules (an unused `partition()` binding, and worker/buildbot.tac's HALIDE_BB_MASTER_PORT default, which was passed to os.environ.get() as an int instead of a str, so port stayed a str whenever the env var was actually set); ty's renamed unresolved-attribute rule and a stale `ty: ignore` comment it now correctly flags as unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tyfrom 0.0.16 to 0.0.65 andrufffrom 0.15.0 to 0.16.0 (pyproject.toml, master/pyproject.toml, .pre-commit-config.yaml, uv.lock).master/master.cfg,master/custom_steps.py,worker/buildbot.tac.RUF059: unusedsepfromhalide_target.partition("/")inmaster/master.cfg— renamed to_sep.PLW1508:worker/buildbot.tac'sHALIDE_BB_MASTER_PORTdefault was passed toos.environ.get()as anint, soportstayed astrwhenever the env var was actually set (a real latent bug, not just a lint nit) — nowint(os.environ.get(..., "9990")).ty'sunresolved-attributerule rename and a stale# ty: ignorecomment it now correctly flags as unused.Test plan
pre-commit run --all-filespasses locallybuildbot checkconfigpasses locally