Cancel stale PR builds on new pushes - #365
Merged
Merged
Conversation
OldBuildCanceller was already instantiated but with an empty filter list, making it a no-op. Populate it to track all builders on any refs/pull/* branch so that a new push to a PR cancels older pending or running builds for that same PR, instead of letting them run to completion alongside the new build. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OldBuildCancellerwas already imported and instantiated inmaster.cfgbut with an empty filter list, making it a no-op.refs/pull/*branch, so a new push to a PR cancels older pending/running build requests for that same PR instead of letting them run alongside the new build.main/release/*pushes are untouched (filter is scoped torefs/pull/).Test plan
🤖 Generated with Claude Code