Avoid processexecutor causing crash on startup#1036
Open
oyvindln wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why this isn't happening with the nix build setup, maybe something changed between python versions.
On my setup and on some of the vhs-decode builders at least ld-decode etc crashes on startup when trying to submit the kaiser lut generator function to the ProcessPoolExecutor. I changed it to a ThreadPoolExecutor instead as a quick workaround since that just uses python threads and avoids any new context mess though not sure if it's an optimal solution.
Also did some minor formatting/cleanup while at it.