Skip to content

fix: edge tts v1 fixed#827

Closed
mehmetgencdal wants to merge 4 commits intoharry0703:mainfrom
mehmetgencdal:main
Closed

fix: edge tts v1 fixed#827
mehmetgencdal wants to merge 4 commits intoharry0703:mainfrom
mehmetgencdal:main

Conversation

@mehmetgencdal
Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings February 24, 2026 19:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mehmetgencdal mehmetgencdal changed the title fix: requirements versions fixed for colab fix: edge tts v1 fixed Feb 26, 2026
@mehmetgencdal mehmetgencdal closed this by deleting the head repository Apr 2, 2026
Copy link
Copy Markdown
Owner

Triage note after reviewing this branch against the current main: I do not recommend reopening or merging this patch in its current form.

The main reason is scope and regression risk. Besides the Edge TTS changes, this branch also replaces the existing subtitle post-processing with raw sub_maker.get_srt() output and broadens unrelated dependency versions (fastapi, uvicorn). That makes the patch much larger than the reported fix and increases the chance of behavior changes in subtitle formatting and runtime compatibility.

This branch also appears to be superseded by smaller follow-up fixes that are already in main (for example the dependency updates merged separately). There are no targeted tests here proving that subtitle generation still matches the current punctuation-aware flow.

Recommendation: keep this PR closed. If there is still an Edge TTS compatibility issue to address, please open a new minimal PR on top of the latest main with focused changes and regression tests for both audio generation and subtitle output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants