Refactored the code to enable the use of plugins. Considering new features (This is still a WIP, See below for more info)#84
Open
DeadIndian wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
I know that you might be busy with you own stuff, so really sorry for putting this burden on you 😅 I also have a few things to discuss reg. how we will implement the plugin ecosystem (mainly reg. dependency management with plugins, version management, and moderating on what goes into the marketplace) , but just wanted to make sure that you were on board with this idea before we proceed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So basically I added plugin functionality, but halfway through adding this I got an idea, why don't we make this into a proper ecosystem....? Like allow people to publish their plugins as npm packages and give server owners a GUI to help them easily add plugins (Ofc bigger plugins will need a restart of the bot to take effect) but this can significantly improve the UX.
But this is a major step and implementing this will bring in a lot of additional complexity, Before I went all in I just wanted to confirm that you are OK with this, because recently I realised that contributing code is just the beginning, maintaining it is the real issue(I will still be around to help improve and maintain this project, but still you the Owner so its you call), and I cant just put a massive feature dump and expect you to take it all in, so just wanted to make sure you were ok with this.
DO NOT APPROVE THIS PR JUST YET, tell me if this direction is ok with you, I will keep working on this and will add to this and finish it later.