chore: update submodules to use v2 of proto-public dependencies#1100
Open
sanikachavan5 wants to merge 2 commits into
Open
chore: update submodules to use v2 of proto-public dependencies#1100sanikachavan5 wants to merge 2 commits into
sanikachavan5 wants to merge 2 commits into
Conversation
| @@ -1,3 +1,3 @@ | |||
| ```release-note:enhancement | |||
| Update `Update `github.com/hashicorp/consul/proto-public` to v0.6.2. | |||
| Update `Update `github.com/hashicorp/consul/proto-public/v2` to v0.6.2. | |||
Contributor
There was a problem hiding this comment.
Version number is 0.6.2 ?
Same with changelog file name
Contributor
Author
There was a problem hiding this comment.
oh shit, it updated this by mistake
| github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||
| github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect | ||
| github.com/fatih/color v1.16.0 // indirect | ||
| github.com/hashicorp/consul/proto-public v0.6.4 // indirect |
Contributor
There was a problem hiding this comment.
@sanikachavan5 Why is this indirect dependency !
Contributor
Author
There was a problem hiding this comment.
this is done by go mod tidy, I have no control on this
| @@ -0,0 +1,3 @@ | |||
| ```release-note:enhancement | |||
| Update `Update `github.com/hashicorp/consul/proto-public` and `github.com/hashicorp/consul/proto-public` to v2.0.0. | |||
Contributor
There was a problem hiding this comment.
@sanikachavan5 Release notes contains the duplicate text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.