You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Always resolve and use the reusable workflow ref as the checkout ref
Why
PR #58 made pull_request events checkout the PR head repository so changes to .github/actions/dismiss-stale-approvals could be self-tested before merge. That breaks callers in other repositories because their PR head checkout does not contain .github/actions/dismiss-stale-approvals/self-test.sh.
The reusable workflow should run the actual shared action from hashintel/.github regardless of which repository triggered the PR event. Now that this branch lives in hashintel/.github rather than a fork, the OIDC step can run on pull_request events and provide the exact workflow ref for checkout.
Low Risk
Low risk: this only adjusts the reusable workflow’s checkout logic for a composite action, with no product code changes; main risk is mis-resolving the workflow ref and breaking the CI job.
Overview
Ensures the stale-approvals reusable workflow always checks out the dismiss-stale-approvals action from hashintel/.github (using the resolved reusable-workflow ref), instead of conditionally checking out the PR head repo on pull_request events.
Removes the split pull_request vs non-pull_request checkout paths so self-test.sh and the action are consistently sourced from the shared repository across callers.
Reviewed by Cursor Bugbot for commit fca9f5c. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary: Ensures the stale-approvals reusable workflow always checks out the shared dismiss-stale-approvals action from hashintel/.github. Change: Removes the pull_request-specific checkout path and consistently resolves/uses the reusable-workflow ref for checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hashintel/.githubinstead of the PR head repositorypull_requesteventsWhy
PR #58 made
pull_requestevents checkout the PR head repository so changes to.github/actions/dismiss-stale-approvalscould be self-tested before merge. That breaks callers in other repositories because their PR head checkout does not contain.github/actions/dismiss-stale-approvals/self-test.sh.The reusable workflow should run the actual shared action from
hashintel/.githubregardless of which repository triggered the PR event. Now that this branch lives inhashintel/.githubrather than a fork, the OIDC step can run onpull_requestevents and provide the exact workflow ref for checkout.Linear
Tests
.github/actions/dismiss-stale-approvals/self-test.sh