Petrinaut: Remove linter warnings#8731
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
PR SummaryMedium Risk Overview Adds small helpers ( Tightens lifecycle/cleanup in a few places (e.g. LSP client provider, drawer mounting, simulation timeline streaming store, Storybook provider subscriptions, resize drag callback refs) and documents/isolates intentional compiler/lint opt-outs (e.g. runtime visualizer component creation, Reviewed by Cursor Bugbot for commit cc9da36. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it. |
c5fe123 to
87d19e3
Compare
87d19e3 to
b43512e
Compare
577c80f to
a0dd9b1
Compare
b43512e to
b06baf9
Compare
0db5ea7 to
8b177d1
Compare
- Strengthen useLatest JSDoc about which read sites are safe given the layout-effect write. - Make Spreadsheet fully controlled — derive tableData from the prop and clamp selection/focus/editing at render time, dropping the reference-identity SourceKeyedValue pattern that lost local state on parent re-renders with a fresh outer array. - Subscribe per net handle once via a ref-tracked map in the story provider, instead of tearing down every subscription whenever a new net is added. - Extract the duplicated clampIndex helper from the side-bar and search subviews into ui/lib. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4aca92d. Configure here.
4aca92d to
d98a000
Compare
See the output of git range-diff at https://github.com/hashintel/hash/actions/runs/26151312720

🌟 What is the purpose of this PR?
Clean up Petrinaut lint diagnostics after the React Compiler/Oxlint updates, keeping behavior equivalent while replacing duplicated or lint-hostile patterns with clearer local helpers.
🔍 What does this change?
Spreadsheetcontrolled and clamps selection/focus/editing state against current data.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
yarn workspace @hashintel/petrinaut lint:tscyarn workspace @hashintel/petrinaut lint:eslintyarn workspace @hashintel/petrinaut test:unit❓ How to test this?