FE-726: generate ds-helpers styled-system before publishing#8732
Conversation
PR SummaryMedium Risk Overview Adds a local Reviewed by Cursor Bugbot for commit 4fa497b. Bugbot is set up for automated code reviews on this repo. Configure here. |
🤖 Augment PR SummarySummary: Ensures the published 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 54853b1. Configure here.
569349d to
bca3f59
Compare


🌟 What is the purpose of this PR?
Ensure the generated Panda
styled-system/files are present in the@hashintel/ds-helpersnpm tarball when the package is packed/published, without committing that generated output to git.This fixes the broken
@hashintel/ds-helpers@0.2.0package shape reported in FE-726, where the published tarball included export paths pointing atstyled-system/but omitted the generated directory itself.🔗 Related links
@hashintel/ds-helpers@0.2.0published tarball is missing the entirestyled-system/directory #8719🚫 Blocked by
🔍 What does this change?
prepackscript to@hashintel/ds-helpersso packaging runs Turbo codegen before npm assembles the tarball.codegenscript for@hashintel/ds-helpers, making it addressable in the Turbo graph.libs/@hashintel/ds-helpers/turbo.jsonsods-helpers#codegendepends on@hashintel/ds-components#codegen, which is the source-owned generator that writes../ds-helpers/styled-system.ds-helpers#buildlocally to avoid a Turbo dependency cycle while preservingstyled-system/as generated, gitignored output.@hashintel/ds-helpers.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
turbo.json's have been updated to reflect thisThe already-published
@hashintel/ds-helpers@0.2.0tarball cannot be changed in place; this will publish a patched package version with the generated files included.🐾 Next steps
After merge, publish the changeset release for
@hashintel/ds-helpersso consumers can upgrade to the fixed package version.🛡 What tests cover this?
npm pack --dry-run --jsonfromlibs/@hashintel/ds-helpers, after deleting localstyled-system/.turbo run codegen --filter @hashintel/ds-helpers.❓ How to test this?
rm -rf libs/@hashintel/ds-helpers/styled-systemcd libs/@hashintel/ds-helpers && npm pack --dry-run --jsonprepackrunsturbo run codegen --filter @hashintel/ds-helpers.styled-system/files, e.g.styled-system/css/index.mjsandstyled-system/tokens/index.mjs.📹 Demo
N/A — packaging fix only.