Skip to content

SRE-884: Remove the legacy health endpoints - #9133

Merged
TimDiekmann merged 7 commits into
mainfrom
t/sre-884-remove-the-legacy-health-endpoints
Aug 3, 2026
Merged

SRE-884: Remove the legacy health endpoints#9133
TimDiekmann merged 7 commits into
mainfrom
t/sre-884-remove-the-legacy-health-endpoints

Conversation

@TimDiekmann

Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

Removes the probe endpoints that #9132 kept alive only so the probe definitions in internal-infra could move to GET /health independently of that deploy.

Do not merge before internal-infra has switched. Merging early takes the probes out from under the ALB target groups and container healthchecks that still point at the old paths.

🔗 Related links

🚫 Blocked by

🔍 What does this change?

  • Drops /health-check from the Node API.
  • Drops /status from Atlas, leaving the health probe as its only route.
  • petrinaut-opt keeps its /status, which is not a probe — it returns the status of every optimization run.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

  • The dropped_spans map in internal-infra lists span names for the removed endpoints. Those entries become dead, but its own validation rejects an empty map, so emptying it is not an option — the internal-infra change has to keep a placeholder or relax the Alloy filter.

🐾 Next steps

  • Nothing. This is the last step of the migration.

🛡 What tests cover this?

  • No new tests. This deletes routes; the Atlas healthcheck test in apps/hash-graph/src/subcommand/atlas.rs continues to cover the remaining one.

❓ How to test this?

  1. Start the Node API and confirm curl -i localhost:5001/health-check answers 404 while /health still answers 200.
  2. Run cargo run --bin hash-graph -- atlas and confirm the same for /status against /health.

📹 Demo

Not applicable — no user-facing surface.

Sentry was authoring the HTTP server spans. Setting `tracesSampleRate` at
all — `0` included, since the check is for nullish — enables Sentry's
server-span and performance integrations, and those write into the globally
registered provider with Sentry's own semantics, where a 404 becomes an
error. `skipOpenTelemetrySetup` keeps them from ever reaching Sentry, so
the only effect was skewing what Tempo derives from them.

Kratos answers `GET /sessions/whoami` with 401 for "no session" and 403 for
AAL1, both defined outcomes rather than failed calls. A rule table marks
those successful and tags them `hash.expected_client_status`, because
`parseResponseStatus` never yields OK on its own and the status would
otherwise be indistinguishable from a suppressed failure.

`getUserAndSession` also stops asking Kratos when there is neither a cookie
nor a session token, which can only be answered with a 401. The auth
middleware runs before routing, so every anonymous request paid that round
trip, including ones for paths matching no route.
Every GraphQL request shares one server span name, and that span is what
Tempo's `span_metrics` and `service_graphs` processors read, so per-operation
views could not be built from them. The operation goes on as an attribute
rather than into the span name, because operation names come from the client
and a name would let a caller mint a metric series per request.
Probe paths differed per service — `/health` on the graph binaries and the
Temporal workers, `/health-check` on the Node API, nothing at all on
petrinaut-opt — so every consumer carried per-service special cases. Each
service now answers `GET /health` with `{"status":"pass"}` as
`application/health+json`, following the only member
`draft-inadarei-api-health-check` requires.

The old paths stay in place so the probe definitions in internal-infra can
switch independently of this deploy.

Probes are excluded from tracing in the two places that create HTTP server
spans: `HttpTracingLayer` returns a disabled span for the path, and
`createHttpInstrumentation` ignores it, which covers the Node API and both
workers at once. Without that, a probe answered every few seconds per task
would dominate the RED metrics derived from spans. The graph API's `/health`
was already untraced, but only as a side effect of being merged after the
layers, which the explicit filter no longer depends on.

Probes stay free of dependency checks: one that reaches through to Postgres
takes every task out of rotation as soon as Postgres is slow. The worker
health server now also answers HEAD, which is what the `hash-graph`
healthcheck subcommand and `wget --spider` issue.

petrinaut-opt's `/status` is unrelated to health — it returns the status of
every optimization run — so it keeps it and gains `/health`.
Also renames the Atlas healthcheck test, which named the endpoint it probes.
@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview Aug 3, 2026 5:41pm
hashdotdesign-tokens Ready Ready Preview Aug 3, 2026 5:41pm
petrinaut Ready Ready Preview Aug 3, 2026 5:41pm

@TimDiekmann TimDiekmann self-assigned this Jul 31, 2026
@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) type/eng > backend Owned by the @backend team area/apps area/apps > hash-graph labels Jul 31, 2026
`HEALTHCHECK` ships inside the image, and the same image now serves `/health`,
so the container probe can move with it. The graph binaries have no
`HEALTHCHECK` — their compose healthchecks call `hash-graph … --healthcheck`,
which follows the path change on its own — and both Temporal workers were
already on `/health`.
`/health-check` on the Node API and `/status` on Atlas were kept alive only so
the probe definitions in internal-infra could move to `/health` independently of
that deploy. Both are now unused.

petrinaut-opt keeps its `/status`, which is not a probe — it returns the status
of every optimization run.
@TimDiekmann
TimDiekmann force-pushed the t/sre-884-remove-the-legacy-health-endpoints branch from 49a09e6 to 38b2829 Compare July 31, 2026 17:59
@TimDiekmann
TimDiekmann marked this pull request as ready for review July 31, 2026 18:04
Copilot AI review requested due to automatic review settings July 31, 2026 18:04
@cursor

cursor Bot commented Jul 31, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Low code risk (route deletion only), but merging before infra switches probes will fail load balancer and container health checks on the removed paths.

Overview
Completes the health-endpoint migration by removing the temporary legacy routes that existed only while internal-infra moved probes to GET /health.

The Node API no longer serves /health-check; liveness stays on the existing early HEALTH_PATH handler. Atlas drops the merged /status route and exposes only probe::router() (still /health), with related axum imports cleaned up.

Deploy coordination: merging before internal-infra retargets ALB/container health checks will break probes on the old paths.

Reviewed by Cursor Bugbot for commit 20acae5. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Base automatically changed from t/sre-854-unify-service-health-endpoints-on-get-health to main August 3, 2026 13:12
@github-actions github-actions Bot added the area/libs Relates to first-party libraries/crates/packages (area) label Aug 3, 2026
@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.55%. Comparing base (ac5ec9c) to head (20acae5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9133      +/-   ##
==========================================
- Coverage   59.57%   59.55%   -0.02%     
==========================================
  Files        1413     1409       -4     
  Lines      138053   137832     -221     
  Branches     6510     6442      -68     
==========================================
- Hits        82240    82092     -148     
+ Misses      54771    54731      -40     
+ Partials     1042     1009      -33     
Flag Coverage Δ
apps.hash-ai-worker-ts 1.99% <ø> (ø)
apps.hash-api 12.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TimDiekmann

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

Copilot AI review requested due to automatic review settings August 3, 2026 17:32

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in commit 20acae5.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@TimDiekmann
TimDiekmann added this pull request to the merge queue Aug 3, 2026
Merged via the queue into main with commit 2f13c99 Aug 3, 2026
59 checks passed
@TimDiekmann
TimDiekmann deleted the t/sre-884-remove-the-legacy-health-endpoints branch August 3, 2026 18:12
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

policy_resolution_large

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 2002 $$25.2 \mathrm{ms} \pm 145 \mathrm{μs}\left({\color{gray}-0.663 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$3.42 \mathrm{ms} \pm 28.7 \mathrm{μs}\left({\color{gray}0.916 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 1002 $$12.0 \mathrm{ms} \pm 91.5 \mathrm{μs}\left({\color{gray}0.371 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 3314 $$41.8 \mathrm{ms} \pm 337 \mathrm{μs}\left({\color{gray}0.542 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$14.2 \mathrm{ms} \pm 118 \mathrm{μs}\left({\color{gray}1.55 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 1527 $$23.2 \mathrm{ms} \pm 149 \mathrm{μs}\left({\color{gray}0.002 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 2078 $$26.3 \mathrm{ms} \pm 194 \mathrm{μs}\left({\color{gray}0.141 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$3.69 \mathrm{ms} \pm 13.6 \mathrm{μs}\left({\color{gray}-0.116 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 1033 $$13.1 \mathrm{ms} \pm 95.3 \mathrm{μs}\left({\color{gray}0.042 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_medium

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 102 $$3.72 \mathrm{ms} \pm 23.3 \mathrm{μs}\left({\color{gray}0.246 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$2.96 \mathrm{ms} \pm 11.0 \mathrm{μs}\left({\color{gray}0.008 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 52 $$3.34 \mathrm{ms} \pm 18.6 \mathrm{μs}\left({\color{gray}0.114 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 269 $$5.02 \mathrm{ms} \pm 23.2 \mathrm{μs}\left({\color{gray}-0.742 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$3.54 \mathrm{ms} \pm 17.9 \mathrm{μs}\left({\color{gray}1.49 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 108 $$4.09 \mathrm{ms} \pm 27.0 \mathrm{μs}\left({\color{gray}0.284 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 133 $$4.32 \mathrm{ms} \pm 38.0 \mathrm{μs}\left({\color{gray}-0.743 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$3.44 \mathrm{ms} \pm 17.1 \mathrm{μs}\left({\color{gray}0.041 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 63 $$4.09 \mathrm{ms} \pm 23.7 \mathrm{μs}\left({\color{gray}1.50 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_none

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 2 $$2.67 \mathrm{ms} \pm 18.3 \mathrm{μs}\left({\color{gray}0.309 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$2.51 \mathrm{ms} \pm 12.6 \mathrm{μs}\left({\color{gray}0.145 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 2 $$2.66 \mathrm{ms} \pm 16.8 \mathrm{μs}\left({\color{gray}0.901 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 8 $$2.92 \mathrm{ms} \pm 17.7 \mathrm{μs}\left({\color{gray}0.687 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$2.72 \mathrm{ms} \pm 12.3 \mathrm{μs}\left({\color{gray}-0.273 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 3 $$2.93 \mathrm{ms} \pm 15.3 \mathrm{μs}\left({\color{gray}0.195 \mathrm{\%}}\right) $$ Flame Graph

policy_resolution_small

Function Value Mean Flame graphs
resolve_policies_for_actor user: empty, selectivity: high, policies: 52 $$3.01 \mathrm{ms} \pm 14.2 \mathrm{μs}\left({\color{gray}0.533 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: low, policies: 1 $$2.73 \mathrm{ms} \pm 12.5 \mathrm{μs}\left({\color{gray}-0.400 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: empty, selectivity: medium, policies: 26 $$2.90 \mathrm{ms} \pm 13.4 \mathrm{μs}\left({\color{gray}-0.757 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: high, policies: 94 $$3.38 \mathrm{ms} \pm 23.3 \mathrm{μs}\left({\color{gray}-0.668 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: low, policies: 1 $$2.97 \mathrm{ms} \pm 11.0 \mathrm{μs}\left({\color{gray}-0.604 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: seeded, selectivity: medium, policies: 27 $$3.21 \mathrm{ms} \pm 13.5 \mathrm{μs}\left({\color{gray}0.061 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: high, policies: 66 $$3.31 \mathrm{ms} \pm 14.5 \mathrm{μs}\left({\color{gray}0.331 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: low, policies: 1 $$2.94 \mathrm{ms} \pm 13.2 \mathrm{μs}\left({\color{gray}-0.626 \mathrm{\%}}\right) $$ Flame Graph
resolve_policies_for_actor user: system, selectivity: medium, policies: 29 $$3.19 \mathrm{ms} \pm 15.0 \mathrm{μs}\left({\color{gray}-0.329 \mathrm{\%}}\right) $$ Flame Graph

read_scaling_complete

Function Value Mean Flame graphs
entity_by_id;one_depth 1 entities $$42.2 \mathrm{ms} \pm 206 \mathrm{μs}\left({\color{gray}1.43 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 10 entities $$33.1 \mathrm{ms} \pm 179 \mathrm{μs}\left({\color{gray}1.22 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 25 entities $$35.3 \mathrm{ms} \pm 216 \mathrm{μs}\left({\color{gray}0.324 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 5 entities $$31.6 \mathrm{ms} \pm 138 \mathrm{μs}\left({\color{gray}-0.070 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;one_depth 50 entities $$42.2 \mathrm{ms} \pm 238 \mathrm{μs}\left({\color{gray}0.655 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 1 entities $$49.1 \mathrm{ms} \pm 208 \mathrm{μs}\left({\color{gray}0.862 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 10 entities $$40.2 \mathrm{ms} \pm 232 \mathrm{μs}\left({\color{gray}2.45 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 25 entities $$88.0 \mathrm{ms} \pm 471 \mathrm{μs}\left({\color{gray}-2.579 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 5 entities $$33.9 \mathrm{ms} \pm 205 \mathrm{μs}\left({\color{gray}1.18 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;two_depth 50 entities $$248 \mathrm{ms} \pm 840 \mathrm{μs}\left({\color{lightgreen}-16.993 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 1 entities $$10.7 \mathrm{ms} \pm 50.4 \mathrm{μs}\left({\color{gray}-0.448 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 10 entities $$10.9 \mathrm{ms} \pm 74.3 \mathrm{μs}\left({\color{gray}-0.105 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 25 entities $$10.9 \mathrm{ms} \pm 47.6 \mathrm{μs}\left({\color{gray}-0.297 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 5 entities $$10.8 \mathrm{ms} \pm 53.2 \mathrm{μs}\left({\color{gray}-0.704 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id;zero_depth 50 entities $$10.9 \mathrm{ms} \pm 47.8 \mathrm{μs}\left({\color{gray}0.004 \mathrm{\%}}\right) $$ Flame Graph

read_scaling_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$10.8 \mathrm{ms} \pm 51.7 \mathrm{μs}\left({\color{gray}-0.269 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$10.9 \mathrm{ms} \pm 57.1 \mathrm{μs}\left({\color{gray}0.144 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$11.0 \mathrm{ms} \pm 62.3 \mathrm{μs}\left({\color{gray}0.677 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$10.9 \mathrm{ms} \pm 48.2 \mathrm{μs}\left({\color{gray}-0.621 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$11.2 \mathrm{ms} \pm 59.4 \mathrm{μs}\left({\color{gray}-0.258 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$11.3 \mathrm{ms} \pm 54.0 \mathrm{μs}\left({\color{gray}0.758 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$11.3 \mathrm{ms} \pm 64.9 \mathrm{μs}\left({\color{gray}0.415 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$11.2 \mathrm{ms} \pm 61.2 \mathrm{μs}\left({\color{gray}-0.138 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$11.2 \mathrm{ms} \pm 59.0 \mathrm{μs}\left({\color{gray}-1.303 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$11.2 \mathrm{ms} \pm 58.0 \mathrm{μs}\left({\color{gray}-2.171 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$11.4 \mathrm{ms} \pm 60.7 \mathrm{μs}\left({\color{gray}1.79 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$11.2 \mathrm{ms} \pm 50.4 \mathrm{μs}\left({\color{gray}-0.704 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$11.5 \mathrm{ms} \pm 64.7 \mathrm{μs}\left({\color{gray}0.975 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$11.3 \mathrm{ms} \pm 59.0 \mathrm{μs}\left({\color{gray}0.472 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: bf5a9ef5-dc3b-43cf-a291-6210c0321eba $$8.31 \mathrm{ms} \pm 44.6 \mathrm{μs}\left({\color{gray}0.010 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property traversal_paths=0 0 $$56.7 \mathrm{ms} \pm 343 \mathrm{μs}\left({\color{gray}4.48 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=255 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true $$108 \mathrm{ms} \pm 551 \mathrm{μs}\left({\color{gray}2.32 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false $$65.1 \mathrm{ms} \pm 482 \mathrm{μs}\left({\color{gray}4.37 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true $$74.0 \mathrm{ms} \pm 527 \mathrm{μs}\left({\color{gray}3.99 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true $$83.0 \mathrm{ms} \pm 435 \mathrm{μs}\left({\color{gray}3.81 \mathrm{\%}}\right) $$
entity_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true $$88.0 \mathrm{ms} \pm 453 \mathrm{μs}\left({\color{gray}2.41 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=0 0 $$43.0 \mathrm{ms} \pm 248 \mathrm{μs}\left({\color{gray}1.36 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=255 1,resolve_depths=inherit:1;values:255;properties:255;links:127;link_dests:126;type:true $$70.5 \mathrm{ms} \pm 260 \mathrm{μs}\left({\color{gray}0.086 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:0;link_dests:0;type:false $$49.3 \mathrm{ms} \pm 310 \mathrm{μs}\left({\color{gray}1.37 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:0;links:1;link_dests:0;type:true $$58.7 \mathrm{ms} \pm 426 \mathrm{μs}\left({\color{gray}1.47 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:0;properties:2;links:1;link_dests:0;type:true $$61.1 \mathrm{ms} \pm 390 \mathrm{μs}\left({\color{gray}1.65 \mathrm{\%}}\right) $$
link_by_source_by_property traversal_paths=2 1,resolve_depths=inherit:0;values:2;properties:2;links:1;link_dests:0;type:true $$60.5 \mathrm{ms} \pm 318 \mathrm{μs}\left({\color{gray}0.632 \mathrm{\%}}\right) $$

scenarios

Function Value Mean Flame graphs
full_test query-limited $$130 \mathrm{ms} \pm 607 \mathrm{μs}\left({\color{red}5.12 \mathrm{\%}}\right) $$ Flame Graph
full_test query-unlimited $$139 \mathrm{ms} \pm 412 \mathrm{μs}\left({\color{gray}3.35 \mathrm{\%}}\right) $$ Flame Graph
linked_queries query-limited $$23.6 \mathrm{ms} \pm 162 \mathrm{μs}\left({\color{red}25.9 \mathrm{\%}}\right) $$ Flame Graph
linked_queries query-unlimited $$533 \mathrm{ms} \pm 777 \mathrm{μs}\left({\color{gray}-3.524 \mathrm{\%}}\right) $$ Flame Graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps > hash-graph area/apps type/eng > backend Owned by the @backend team

Development

Successfully merging this pull request may close these issues.

4 participants