Skip to content

remove datestamp from bootstrap cache keys#11613

Merged
mergify[bot] merged 1 commit intohaskell:masterfrom
geekosaur:remove-bootstrap-cache-timestamp
Mar 28, 2026
Merged

remove datestamp from bootstrap cache keys#11613
mergify[bot] merged 1 commit intohaskell:masterfrom
geekosaur:remove-bootstrap-cache-timestamp

Conversation

@geekosaur
Copy link
Copy Markdown
Collaborator

@geekosaur geekosaur commented Mar 12, 2026 •
edited
Loading

The intent behind the datestamps was to avoid accumulating out of date source tarballs — which we've been doing since 2022, because nobody's been updating it.

Use a hash computed from the bootstrap JSONs instead, which will be self-updating.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur
Copy link
Copy Markdown
Collaborator Author

geekosaur commented Mar 12, 2026 •
edited
Loading

EDIT: this comment is now historical; the first version removed the datestamp entirely, because nobody knew why it was there.

On second thought, I'm probably closing this in favor of adding a reminder to update the datestamp to things that update the bootstrap JSONs. The problem is that we'll accumulate older versions of source packages. (And probably already have such accumulation, since we haven't been updating the datestamp.)

Comments?

@geekosaur
Copy link
Copy Markdown
Collaborator Author

geekosaur commented Mar 12, 2026

Actually, appropriate keys can be computed dynamically by using hashFiles on the bootstrap JSONs, so the next push will do that instead. Existing caches will be matched by restore-keys, in effect upgrading them without losing existing cached downloads.

@geekosaur
Copy link
Copy Markdown
Collaborator Author

geekosaur commented Mar 12, 2026

Wait, if I save the existing caches we save 4 years of outdated source tarballs. Guess they just have to go.

@geekosaur geekosaur force-pushed the remove-bootstrap-cache-timestamp branch from faeed08 to 052834d Compare March 12, 2026 23:11
@geekosaur geekosaur force-pushed the remove-bootstrap-cache-timestamp branch 3 times, most recently from 4a0b19c to ddb8407 Compare March 13, 2026 00:04
@geekosaur
Copy link
Copy Markdown
Collaborator Author

geekosaur commented Mar 13, 2026

Uh, anyone know if it's safe to swap the checkout and cache steps? Because it's kinda hard to compute a hash for a file that doesn't exist yet.

@geekosaur geekosaur force-pushed the remove-bootstrap-cache-timestamp branch from ddb8407 to 950755f Compare March 13, 2026 00:11
@geekosaur
Copy link
Copy Markdown
Collaborator Author

geekosaur commented Mar 13, 2026

Hackage is "down" again, but at least the cache keys now work properly.

@geekosaur
use hash instead of date in bootstrap cache keys
b570a10 
Without some distinct identifier, downloaded sources will accumulate
(and have been since the last time the datestamp was updated).

The old caches are ignored and will be purged according to GitHub's
cache expiration, because otherwise we'd continue to carry 4 years'
worth of outdated source tarballs.
@geekosaur geekosaur force-pushed the remove-bootstrap-cache-timestamp branch from 950755f to b570a10 Compare March 13, 2026 00:33
Mikolaj
Mikolaj approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekosaur geekosaur added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Mar 26, 2026
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Mar 26, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 28, 2026 •
edited
Loading

Merge Queue Status

This pull request spent 1 hour 52 minutes 43 seconds in the queue, including 1 hour 42 minutes 14 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify bot added a commit that referenced this pull request Mar 28, 2026
@mergify
Merge of #11613
66cdf52
@mergify mergify bot mentioned this pull request Mar 28, 2026
Closed
86 tasks
@mergify mergify bot merged commit 3e4a5fb into haskell:master Mar 28, 2026
212 of 220 checks passed
@mergify mergify bot removed the queued label Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mikolaj Mikolaj Mikolaj approved these changes

@ffaf1 ffaf1 ffaf1 approved these changes

Assignees

No one assigned

Labels

continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geekosaur @Mikolaj @ffaf1