Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 2.0.0.0#11630
Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 2.0.0.0#11630zlonast wants to merge 2 commits intohaskell:masterfrom
Conversation
|
Should we drop compilers below 8.6? Or 8.8? |
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
3 times, most recently
from
1cd54e4 to
27e6671
Compare
|
This does modify behaviour, does it not? |
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
2 times, most recently
from
9f262e4 to
2547133
Compare
|
@ffaf1 It seems to me that if I can't compile the code with an old compiler, then this doesn't count as a change in behavior. |
Makes sense! |
| , Z.zVersionDigits = show $ versionNumbers $ packageVersion pkg_descr | ||
| , Z.zSupportsCpp = supports_cpp | ||
| , Z.zSupportsNoRebindableSyntax = supports_rebindable_syntax | ||
| , Z.zSupportsCpp = True |
There was a problem hiding this comment.
This is the same problem, is it not?
Will zSuppoerCpp ever be False?
Or is it different?
There was a problem hiding this comment.
I thought about it and tried to remove as much code as possible that just looks like True or False
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
from
314c399 to
ca8e7bb
Compare
zlonast
changed the title
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
from
9e5e88e to
f0bc384
Compare
zlonast
force-pushed
the
zlonast/old-mkVersion
branch
from
fce4414 to
3b62aac
Compare
🤔 |
changelog.d/11630.md
Outdated
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| synopsis: "We just dropped everything below (ghc 8.0.0, base 4.9.0.0, cabal 2.0.0.0)" | |||
| packages: [cabal-dev-scripts, cabal-install-solver, cabal-install, Cabal-syntax, Cabal] | |||
There was a problem hiding this comment.
We do not release cabal-dev-scripts, so you can remove it from here.
changelog.d/11630.md
Outdated
| We don't have any testing for such old versions of ghc. | ||
| Since this code isn't used, I assume it doesn't work, | ||
| but it's difficult to confirm otherwise. | ||
|
|
There was a problem hiding this comment.
This is going to end up in release notes, sentences with “I” do not conform to a normal changelog style.
Just say we drop support fro anything below xyz.
changelog.d/11630.md
Outdated
| @@ -0,0 +1,11 @@ | |||
| --- | |||
| synopsis: "We just dropped everything below (ghc 8.0.0, base 4.9.0.0, cabal 2.0.0.0)" | |||
There was a problem hiding this comment.
Remove "",
| synopsis: "We just dropped everything below (ghc 8.0.0, base 4.9.0.0, cabal 2.0.0.0)" | |
| synopsis: Drop support for anything below GHC 8.0.0, base 4.9.0.0, Cabal 2.0.0.0 |
zlonast
changed the title
4 participants
We don't have any testing for such old versions of ghc. Since this code isn't used, I assume it doesn't work, but it's difficult to confirm otherwise.
We just dropped everything below (ghc 8.0.0, base 4.9.0.0, cabal 2.0.0.0)
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.