You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this PR I add basic support for mhs's Solo, and fiddle with the Hashable instance generation so that it'll work for mhs.
I don't add mhs to the ci like QuickCheck does because their thing seems to be an odd script; I can look into that in future if that would be appreciated.
I however will change conditionals in .cabal file to not explicitly refer to GHC either: #34 that should work for MicroHs too, if their base is the same (enough) as one GHC ships.
That's something MicroHS developers have to solve. I won't add if !impl(ghc) buildable: False to TH using components. The build system should be able to allow me to declare that declaratively without hunting down which compilers support it or not. (FWIW, not all GHCs support splicing TH either, so it's not a new problem; it just was swiped under the rug since TH was invented).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changlog entry below.
In this PR I add basic support for mhs's Solo, and fiddle with the Hashable instance generation so that it'll work for mhs.
I don't add mhs to the ci like QuickCheck does because their thing seems to be an odd script; I can look into that in future if that would be appreciated.
This is part of my ongoing work with nick8325/quickcheck#472.
Changelog entry: