Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues and PRs:
This PR introduces a custom
Intervaltype because the duration types provided by thetimelibrary do not match theintervaltype in Postgres (months :: Int32, days :: Int32, microseconds :: Int64):DiffTime: not appropriateNominalDiffTime: only handles seconds (not days or months), allows picosecond precision (rather than micro), allows arbitrarily large durationsCalendarDiffTime: does not separate days from monthsCalendarDiffDays: does not handle secondsUnlike the existing
FromFieldinstance forCalendarDiffTime, this does not require a particularintervalstyleto be set in Postgres.