[HZ-5434] FencedLock for Asyncio#818
Open
yuce wants to merge 23 commits into
Open
Conversation
# Conflicts: # hazelcast/internal/asyncio_client.py
# Conflicts: # hazelcast/asyncio/__init__.py
# Conflicts: # hazelcast/asyncio/__init__.py
# Conflicts: # hazelcast/asyncio/__init__.py # hazelcast/internal/asyncio_proxy/cp_manager.py
# Conflicts: # hazelcast/asyncio/__init__.py # hazelcast/internal/asyncio_proxy/cp_manager.py
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
==========================================
- Coverage 94.21% 94.17% -0.05%
==========================================
Files 410 411 +1
Lines 27318 27492 +174
==========================================
+ Hits 25739 25890 +151
- Misses 1579 1602 +23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported
FencedLockproxy to asyncio.The asyncore variant uses actual thread IDs to disable re-entrancy.
That's not useful with the asyncio variant, so currently the thread ID
0is used when necessary.I've omitted docs that refer to threads, and tests that use threads.
I'll push another PR to add those after lock context implementation.