fix(hero): make the top strip reflect the user's own scan, drop the XC dashboard link - #59
Merged
Conversation
The ④ Mitigate "Apply on your own NGINX" panel + its help told the operator to set NGINX_SSH_* "in ⚙ Setup", but Setup had no NGINX fields — the only way to point it at the box was hand-editing .env. Added the NGINX_SSH_* keys to MANAGED_KEYS (so the generic Setup config editor renders them as fields) with NGINX_SSH_PASSWORD in SECRET_KEYS (the key PATH is not secret), plus a NGINX + App Protect card in Setup's Advanced integrations with a live status readout (loadNginx → /api/nginx-lab), mirroring the BIG-IP card. +2 tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…C dashboard link The persistent hero band (console + standalone report) mixed real scan-derived numbers with two things that were not the user's data: - a fixed "vs 25 days normal change control · N× faster" contrast (CHANGE_CONTROL_DAYS defaulted to 25 — a narrative baseline, not a scan number) - a hardcoded "mitigated live by XC" label, wrong now that a band-aid can land on BIG-IP or NGINX And a persistent "XC security dashboard ↗" link the operator asked to remove. Changes: - change_control_days() returns None when CHANGE_CONTROL_DAYS is unset; impact() omits the contrast and the derived speedup unless the operator opts in. - impact() exposes points_live (bigip_awaf→BIG-IP, nginx_app_protect→NGINX, else XC), derived from the same set the mitigated count uses so label and number never disagree; the hero label reads "mitigated live · <point>". - Remove the XC dashboard link + its plumbing (hero DASHBOARD var, /api/defaults `dashboard` field). xc_dashboard_url() helper kept (still tested). Full suite: 1182 passed, 15 skipped. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The persistent hero band (console and standalone report) was mixing real scan-derived numbers with data that wasn't the user's — and carried a dashboard link the operator asked to remove.
1. Removed the XC Security Dashboard link
Gone from the top of every UI page (console hero + report). Cleaned up the dead plumbing behind it — the
DASHBOARDJS var and thedashboardfield/api/defaultsserved. Thexc_dashboard_url()library helper is kept (still tested); it's just no longer rendered.2. Top numbers now reflect the active scan, not demo/marketing figures
CHANGE_CONTROL_DAYSused to default to25— a fixed narrative baseline, not a number from the user's scan. It now returnsNonewhen unset, so the "vs N days normal change control" block and the derived "N× faster" speedup are omitted entirely. Set it explicitly and they return.mitigated live by XC→mitigated live · <point>. Hardcoding XC was wrong now that a band-aid can land on BIG-IP or NGINX.impact()exposespoints_live(bigip_awaf→BIG-IP,nginx_app_protect→NGINX, else XC), derived from the same entries themitigatedcount uses so the label can never disagree with the number above it.OUTdir and are unchanged.Tests
test_impact.py: opt-inchange_control_days, contrast/speedup omitted when unset,points_livenames the enforcement point.test_report.py: contrast is opt-in, point-naming label, no dashboard link.🤖 Generated with Claude Code