Skip to content

feat: implement sdk pagination in list commands#3739

Merged
michaelmalave merged 1 commit into
feat/heroku-sdk-integrationfrom
mm/feat/implement-sdk-pagination
Jun 2, 2026
Merged

feat: implement sdk pagination in list commands#3739
michaelmalave merged 1 commit into
feat/heroku-sdk-integrationfrom
mm/feat/implement-sdk-pagination

Conversation

@michaelmalave
Copy link
Copy Markdown
Contributor

Summary

This branch continues the Heroku SDK migration across core CLI command surfaces and related libraries, while cleaning up shared utilities that are no longer needed under the new integration approach. Scope includes command-path refactors, type/test alignment, and migration tooling to support ongoing rollout.

  • Integrate @heroku/sdk usage across addons, apps, maintenance, PG, pipelines, process, logs, domains, features, and spaces command paths
  • Refactor command internals to simplify SDK call patterns and reduce legacy client indirection
  • Remove the shared pagination utility and move pagination behavior into command-level implementations
  • Add SDK migration codemod tooling and supporting skill/docs for follow-on command migrations
  • Update type usage, mocks, and unit tests to match SDK response shapes and revised call flows
  • Adjust dependency/config wiring to support the SDK migration and related command/test updates

Type of Change

  • fix: Bug fix or issue (patch semvar update)
  • feat: Introduces a new feature to the codebase (minor semvar update)
  • perf: Performance improvement
  • docs: Documentation only changes
  • tests: Adding missing tests or correcting existing tests
  • chore: Code cleanup tasks, dependency updates, or other changes

Verification

npm install && npm run build
npm run lint
npm test
# Optional focused suites for migrated command surfaces
npm test -- test/unit/commands/addons
npm test -- test/unit/commands/apps
npm test -- test/unit/commands/data/maintenances
npm test -- test/unit/commands/pg
npm test -- test/unit/commands/pipelines
npm test -- test/unit/commands/ps
npm test -- test/unit/commands/domains/index.unit.test.ts
npm test -- test/unit/commands/features/index.unit.test.ts
npm test -- test/unit/commands/spaces/index.unit.test.ts
npm test -- test/unit/commands/logs.unit.test.ts

Additional Context

  • Breaking: none expected; migration is intended to preserve current CLI UX/output semantics
  • Risk: medium; wide internal refactor across many command surfaces, mitigated by broad unit test updates
  • Follow-up: continue migrating remaining command surfaces with codemod-assisted patterns and monitor SDK typing gaps as they are addressed upstream

Related Issues

GUS work item: W-22800898

…o use in-command pagination patterns, remove the shared paginator utility, and update unit tests to cover the new pagination behavior
@michaelmalave michaelmalave requested a review from a team as a code owner June 2, 2026 19:31
@michaelmalave michaelmalave changed the title feat: implement sdk pagination feat: implement sdk pagination in list commands Jun 2, 2026
Copy link
Copy Markdown
Contributor

@tlowrimore-heroku tlowrimore-heroku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelmalave michaelmalave merged commit 1272838 into feat/heroku-sdk-integration Jun 2, 2026
5 of 18 checks passed
@michaelmalave michaelmalave deleted the mm/feat/implement-sdk-pagination branch June 2, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants