fix: routes controller on node name drift#1221
Open
lukasmetzner wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1221 +/- ##
==========================================
+ Coverage 69.95% 70.34% +0.38%
==========================================
Files 24 24
Lines 2656 2674 +18
==========================================
+ Hits 1858 1881 +23
+ Misses 629 616 -13
- Partials 169 177 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukasmetzner
force-pushed
the
fix/routes-controller-node-name-drift
branch
from
0e99446 to
19d6cf7
Compare
lukasmetzner
force-pushed
the
fix/routes-controller-node-name-drift
branch
from
19d6cf7 to
1382b4c
Compare
lukasmetzner
had a problem deploying
to
e2e-robot
GitHub Actions
Failure
lukasmetzner
force-pushed
the
fix/routes-controller-node-name-drift
branch
from
08a2e3f to
ea742f6
Compare
lukasmetzner
force-pushed
the
fix/routes-controller-node-name-drift
branch
from
ea742f6 to
eb55116
Compare
apricote
reviewed
May 18, 2026
Comment on lines
+148
to
+150
| if node.Spec.ProviderID == "" { | ||
| return nil, nil, fmt.Errorf("%s: node %q not yet initialized", op, node.Name) | ||
| } |
Member
There was a problem hiding this comment.
Is this a breaking change? IIRC it was previously possible to only use the route controller, without the node controller being active.
It feels like we talked about it sometime ago, but I forgot our resolution and there was no public doucmnetation in this PR.
Contributor
Author
There was a problem hiding this comment.
I think we can just make this a soft check and try to find the server via its ID (should be our happy path) and otherwise, fallback to the old behavior.
If a Kubernetes node got successfully initialized we have the Server ID stored in the node objets `providerID`. When renaming a Server, causing a drift between the node and Server name, we should still be able to identify the Server via its ID. This is currently not implemented in the routes' controller, where we rely purly on the Servers name. As the upstream library only provides us with the Kubernetes node name and not the full object, we have to first fetch it from the Kubernetes API. With the node object at hand we can identify and fetch the Server by its ID. Furthermore, we can use the Kubernetes node object to improve our handling of Kubernetes events. The event emitted on a CIDR mismatch is currently not associated with the affected node, because so far we did not have access to the nodes UUID.
lukasmetzner
force-pushed
the
fix/routes-controller-node-name-drift
branch
from
eb55116 to
0796918
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Kubernetes node got successfully initialized we have the Server ID stored in the node objets
providerID. When renaming a Server, causing a drift between the node and Server name, we should still be able to identify the Server via its ID. This is currently not implemented in the routes' controller, where we rely purly on the Servers name.As the upstream library only provides us with the Kubernetes node name and not the full object, we have to first fetch it from the Kubernetes API. With the node object at hand we can identify and fetch the Server by its ID. Furthermore, we can use the Kubernetes node object to improve our handling of Kubernetes events. The event emitted on a CIDR mismatch is currently not associated with the affected node, because so far we did not have access to the nodes UUID.