Skip to content

fix(cloud): make HasClusterID() return true to silence deprecation warning #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arbianshkodra wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

fix(cloud): make HasClusterID() return true to silence deprecation warning #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion hcloud/cloud.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,14 @@ func (c *cloud) ProviderName() string {
}

func (c *cloud) HasClusterID() bool {
return false
// Hetzner does not consume the kubernetes/cloud-provider ClusterID for
// any tagging or reconciliation — see issue #1119, where this was
// confirmed by maintainers. Returning true lets operators omit the
// `--allow-untagged-cloud` flag entirely, which in turn silences the
// upstream deprecation warning ("Flag --allow-untagged-cloud has been
// deprecated, ... A cluster-id will be required on cloud instances.")
// emitted by k8s.io/cloud-provider when the flag is set.
return true
}

// serverIsAttachedToNetwork checks if the server where the master is running on is attached to the configured private network
Expand Down
4 changes: 2 additions & 2 deletions hcloud/cloud_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ func TestCloud(t *testing.T) {
})

t.Run("HasClusterID", func(t *testing.T) {
if cloud.HasClusterID() {
t.Error("HasClusterID should be false")
if !cloud.HasClusterID() {
t.Error("HasClusterID should be true so operators can omit --allow-untagged-cloud (see issue #1119)")
}
})

Expand Down