feat(load-balancer): support http timeout-idle annotation - #1301
Open
lukasmetzner wants to merge 4 commits into
Open
feat(load-balancer): support http timeout-idle annotation#1301lukasmetzner wants to merge 4 commits into
lukasmetzner wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 71.63% 71.85% +0.22%
==========================================
Files 26 27 +1
Lines 2778 2800 +22
==========================================
+ Hits 1990 2012 +22
Misses 613 613
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lukasmetzner
marked this pull request as draft
July 23, 2026 11:51
jooola
reviewed
Jul 23, 2026
lukasmetzner
commented
Jul 28, 2026
|
|
||
| // withInvalidInputFields adds the validation errors of an 'invalid_input' API | ||
| // error to the error message. | ||
| func withInvalidInputFields(err error) error { |
Contributor
Author
There was a problem hiding this comment.
Unfortunately we can't use the hcloud helper here as long as we use klog.
Add the `load-balancer.hetzner.cloud/http-timeout-idle` annotation to configure the idle timeout for the client and server side of an HTTP/HTTPS Load Balancer service. It is documented as the new `duration` type (a Go duration string, e.g. `30s`). Closes #1233
lukasmetzner
force-pushed
the
feat/lb-support-timeout-idle
branch
from
July 28, 2026 15:45
32cb59f to
c830d90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
load-balancer.hetzner.cloud/http-timeout-idleannotation toconfigure the idle timeout for the client and server side of an HTTP/HTTPS
Load Balancer service.
It is documented as the new
durationtype (a Go duration string, e.g.30s).Closes #1233