Skip to content

feat(sdk): can() returns CanResult; T4 dispatch-boundary tests#1426

Open
vanceingalls wants to merge 2 commits into
06-13-fix_sdk_fs_adapter_flush_tracks_in-flight_writes_add_to_t13_contract_suitefrom
06-13-feat_sdk_can_returns_canresult_t4_dispatch-boundary_tests
Open

feat(sdk): can() returns CanResult; T4 dispatch-boundary tests#1426
vanceingalls wants to merge 2 commits into
06-13-fix_sdk_fs_adapter_flush_tracks_in-flight_writes_add_to_t13_contract_suitefrom
06-13-feat_sdk_can_returns_canresult_t4_dispatch-boundary_tests

Conversation

@vanceingalls

Copy link
Copy Markdown
Collaborator

What

Brief description of the change.

Why

Why is this change needed?

How

How was this implemented? Any notable design decisions?

Test plan

How was this tested?

  • Unit tests added/updated
  • Manual testing performed
  • Documentation updated (if applicable)

- setGsapScript: remove element when newScript="" (fixes undo/redo duplicate-script bug)
- parseDeclarations: track quotes so ; inside CSS values (data URIs) doesn't split
- handleRemoveGsapKeyframe: guard against duplicate-percentage ambiguity (return EMPTY)
- resolveKeyframe: return kfs so callers can check uniqueness
- handleSetClassStyle: emit op:"add" (not "replace") when no prior <style> element
- FsAdapter listVersions: Number(f.split("_")[0]) — was NaN due to underscore in key
- FsAdapter doWrite: split try/catch so appendVersion failure doesn't fire error handlers
- FileAdapter playground: add content:"" field to satisfy PersistVersionEntry contract

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant