[agent docs]add reporting guide - #14531
Open
yiyixuxu wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sayakpaul
approved these changes
Aug 19, 2026
|
|
||
| ## Bug reports | ||
|
|
||
| A reproduction is **what you were doing when it broke, with everything unnecessary removed** — start from the real failing situation and delete, don't build a clean synthetic case from scratch. The test: can someone paste it into a terminal and see the same failure, without first accepting your theory of the cause? A script that demonstrates your theory is not a reproduction — it can pass while the real bug is still there. |
Member
There was a problem hiding this comment.
We won't probably be pasting the code into the terminal but rather create a Python file out of the code snippet and run it?
|
|
||
| A reproduction is **what you were doing when it broke, with everything unnecessary removed** — start from the real failing situation and delete, don't build a clean synthetic case from scratch. The test: can someone paste it into a terminal and see the same failure, without first accepting your theory of the cause? A script that demonstrates your theory is not a reproduction — it can pass while the real bug is still there. | ||
|
|
||
| - Keep the real model, settings, and dtype. A repro that downloads weights and takes two minutes is worth more than a fast synthetic one. |
Member
There was a problem hiding this comment.
But we should also ask it to strive to be minimal even in that regard. For example, just using the bare minimum dependencies, and no externalities at all (like invoking diffusers from a servlet for example). Thoughts?
stevhliu
approved these changes
Aug 19, 2026
| @@ -0,0 +1,59 @@ | |||
| # Reporting bugs and performance claims | |||
|
|
|||
| For issues and PR descriptions on this repo, from humans and agents alike. | |||
Member
There was a problem hiding this comment.
Suggested change
| For issues and PR descriptions on this repo, from humans and agents alike. | |
| Use this guide when writing bug reports or performance claims in issues and pull requests. |
|
|
||
| ## Bug reports | ||
|
|
||
| A reproduction is **what you were doing when it broke, with everything unnecessary removed** — start from the real failing situation and delete, don't build a clean synthetic case from scratch. The test: can someone paste it into a terminal and see the same failure, without first accepting your theory of the cause? A script that demonstrates your theory is not a reproduction — it can pass while the real bug is still there. |
Member
There was a problem hiding this comment.
Suggested change
| A reproduction is **what you were doing when it broke, with everything unnecessary removed** — start from the real failing situation and delete, don't build a clean synthetic case from scratch. The test: can someone paste it into a terminal and see the same failure, without first accepting your theory of the cause? A script that demonstrates your theory is not a reproduction — it can pass while the real bug is still there. | |
| A reproduction is the smallest version of the real workflow that still fails. Start with what you were doing when the failure occurred, then remove anything unrelated. Someone should be able to run it and see the same failure without first accepting your theory about its cause. A script that tests your theory is not a reproduction. It may pass even when the real workflow still fails. |
|
|
||
| A reproduction is **what you were doing when it broke, with everything unnecessary removed** — start from the real failing situation and delete, don't build a clean synthetic case from scratch. The test: can someone paste it into a terminal and see the same failure, without first accepting your theory of the cause? A script that demonstrates your theory is not a reproduction — it can pass while the real bug is still there. | ||
|
|
||
| - Keep the real model, settings, and dtype. A repro that downloads weights and takes two minutes is worth more than a fast synthetic one. |
Member
There was a problem hiding this comment.
Suggested change
| - Keep the real model, settings, and dtype. A repro that downloads weights and takes two minutes is worth more than a fast synthetic one. | |
| - Keep the real model, settings, and dtype. A slower repro is better than a faster one that changes the behavior. |
| print(torch.cuda.max_memory_allocated()) | ||
| ``` | ||
|
|
||
| The difference: a maintainer understands the first script at a glance — it's an ordinary pipeline call — while the second is not, and it only demonstrates the reporter's theory: it can go green while the real pipeline still dies on a 24GB card. |
Member
There was a problem hiding this comment.
Suggested change
| The difference: a maintainer understands the first script at a glance — it's an ordinary pipeline call — while the second is not, and it only demonstrates the reporter's theory: it can go green while the real pipeline still dies on a 24GB card. | |
| The first script exposes the real pipeline call. The second only tests the proposed mechanism, so it may pass even when the pipeline still fails. Keep the hypothesis separate from the reproduction. |
|
|
||
| ## Performance claims | ||
|
|
||
| Report **the end-to-end number only**: wall clock for the full pipeline call, before vs. after, on the same hardware, dtype, and seed. That's the number we decide with — if we want op-level detail, we'll ask. |
Member
There was a problem hiding this comment.
Suggested change
| Report **the end-to-end number only**: wall clock for the full pipeline call, before vs. after, on the same hardware, dtype, and seed. That's the number we decide with — if we want op-level detail, we'll ask. | |
| Lead with the end-to-end result: measure the full pipeline call before and after the change on the same hardware, dtype, and seed. Only include lower-level measurements when requested. |
|
|
||
| Report **the end-to-end number only**: wall clock for the full pipeline call, before vs. after, on the same hardware, dtype, and seed. That's the number we decide with — if we want op-level detail, we'll ask. | ||
|
|
||
| Attach the script you measured with, please keep it as simple as possible (see `benchmarks/benchmarking_utils.py`): |
Member
There was a problem hiding this comment.
Suggested change
| Attach the script you measured with, please keep it as simple as possible (see `benchmarks/benchmarking_utils.py`): | |
| Attach the measurement script and keep it as simple as possible. See `benchmarks/benchmarking_utils.py` for the repository's benchmarking helper. |
| print(f"peak memory: {torch.cuda.max_memory_allocated() / 1024**3:.2f}GB") | ||
| ``` | ||
|
|
||
| State the setup (GPU, dtype, torch/diffusers versions, attention backend) and the exact call (model id, resolution/duration, steps, batch size). One-shot timings are noise. |
Member
There was a problem hiding this comment.
Suggested change
| State the setup (GPU, dtype, torch/diffusers versions, attention backend) and the exact call (model id, resolution/duration, steps, batch size). One-shot timings are noise. | |
| State the setup (GPU, dtype, torch/diffusers versions, attention backend) and the exact call (model id, resolution/duration, steps, batch size). One-shot timings are noisy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.