fix(pvera): use _cast_input_dtype in forward instead of raw .to()#3208
Open
Chessing234 wants to merge 1 commit into
Open
fix(pvera): use _cast_input_dtype in forward instead of raw .to()#3208Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Member
|
@Chessing234 Could you please apply all changes of this type in a single PR instead of opening one for each PEFT method individually? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Linear.forwardinsrc/peft/tuners/pvera/layer.pycasts the input tensor withx = x.to(lambda_d.dtype). This bypasses thedisable_lora_input_dtype_castingcontext manager provided byBaseTunerLayer, which is intended to let callers suppress dtype casting during specific operations (e.g. AMP, mixed-precision inference).Root cause
BaseTunerLayer._cast_input_dtypechecksself._disable_lora_input_dtype_castingand is a no-op when the context manager is active. A bare.to(dtype)call has no such guard.Fix
Replace the raw cast with the inherited helper:
This is the same pattern already applied to
vera(#3172),poly(#3177), andfourierft(#3170);pverawas the only tuner that still used the raw.to()call.