fix(tuners): guard child.weight access in _replace_module for non-linear modules#3213
Open
Chessing234 wants to merge 1 commit into
Open
fix(tuners): guard child.weight access in _replace_module for non-linear modules#3213Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
…ear modules When modules_to_save contains non-linear modules (e.g. encoder blocks without weight attributes), _replace_module unconditionally assigns child.weight, raising AttributeError. Add hasattr guard to match the existing pattern used for bias.
Member
|
Thanks for providing this PR. It would be great to add a unit test to catch this error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
_replace_moduleintuners_utils.pyunconditionally assignsnew_module.weight = child.weightwithout checking whetherchildactually has aweightattribute:When
modules_to_savecontains non-linear module blocks (e.g.Siglip2EncoderLayer, full transformer encoder layers, or any module without aweightparameter), callingmerge_and_unload()raises:Root cause: The
biasassignment already useshasattr(child, "bias")as a guard, but theweightassignment has no equivalent guard. Non-linear modules inmodules_to_savelegitimately lackweight.Fix: Add the same
hasattrguard forweightthat already exists forbias:This is a one-line addition matching the existing convention in the same block.