Remove unused parameters and improve add_tensor_parallel_hooks_t…#44768
Open
michaelbenayoun wants to merge 1 commit intohuggingface:mainfrom
Open
Remove unused parameters and improve add_tensor_parallel_hooks_t…#44768michaelbenayoun wants to merge 1 commit intohuggingface:mainfrom
michaelbenayoun wants to merge 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44768&sha=064c3e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
add_tensor_parallel_hooks_to_modulehas unused parameters, in this PR we:tp_plan, which is not used.parameter_namewhich is not usedlayer_name. This parameter is only used for logging purposes, and we can infer it when it does happen. It is a bit more costly, but since it is not supposed to happen, it is ok to proceed like that imo