Fix: Handle empty lists in video_utils functions#44769
Closed
LincolnBurrows2017 wants to merge 4 commits intohuggingface:mainfrom
Closed
Fix: Handle empty lists in video_utils functions#44769LincolnBurrows2017 wants to merge 4 commits intohuggingface:mainfrom
LincolnBurrows2017 wants to merge 4 commits intohuggingface:mainfrom
Conversation
The is_batched_video() and convert_pil_frames_to_video() functions were accessing videos[0] without first checking if the list is empty, causing IndexError when empty lists are passed. This is similar to the fix applied to image_utils.py in commit 4afe016.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
is_batched_video()andconvert_pil_frames_to_video()functions insrc/transformers/video_utils.pywere accessingvideos[0]without first checking if the list is empty, causingIndexErrorwhen empty lists are passed.This is similar to the fix applied to
image_utils.pyin commit 4afe016.Changes
is_batched_video(): Addedlen(videos) > 0 andcheck before accessingvideos[0]convert_pil_frames_to_video(): Added early return[]for empty list inputTesting
The fix handles the following edge cases:
is_batched_video([])- returnsFalseinstead of raisingIndexErrorconvert_pil_frames_to_video([])- returns[]instead of raisingIndexError