Fix TypeError on list-typed ignore_keys_at_rope_validation in RoPE config#46142
Open
Charly21r wants to merge 1 commit into
Open
Fix TypeError on list-typed ignore_keys_at_rope_validation in RoPE config#46142Charly21r wants to merge 1 commit into
Charly21r wants to merge 1 commit into
Conversation
…_validation is a list
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=46142&sha=1267e6 |
Member
|
LGTM, CI issues seem unrelated. It's core code though, so I'll wait for a core maintainer to approve in case I'm totally wrong here! cc @ArthurZucker @Cyrilvallez @vasqu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #46121
RotaryEmbeddingConfigMixin.ignore_keys_at_rope_validationis asetat the class level, but JSON has nosettype, so anyconfig.jsonthat serializes this field (e.g. checkpoints written by LoRA merge / export tooling likems-swift) loads it back as alistinstance attribute that shadows the class default.RotaryEmbeddingConfigMixin.convert_rope_params_to_dictthen does:self.ignore_keys_at_rope_validation = self.ignore_keys_at_rope_validation | {"partial_rotary_factor"}which raises
TypeError: unsupported operand type(s) for |: 'list' and 'set'wheneverpartial_rotary_factoris also set on the config. In practice this prevents serving such merged checkpoints (observed downstream in vLLM with merged Qwen3.5 checkpoints).This PR coerces the attribute to a set before the union in
src/transformers/modeling_rope_utils.py, and adds a regression test intests/utils/test_modeling_rope_utils.pycovering both direct attribute assignment and thefrom_dictround-trip path that mirrors the JSON-deserialization flow.Code Agent Policy
Before submitting
to it if that's the case.
Who can review?
@Rocketknight1