Skip to content

test/test-oracle.ps1: Ignore timezone differences in datetime comparisons#56

Merged
hymkor merged 1 commit into
masterfrom
push-zkzpnvpwnssv
May 11, 2026
Merged

test/test-oracle.ps1: Ignore timezone differences in datetime comparisons#56
hymkor merged 1 commit into
masterfrom
push-zkzpnvpwnssv

Conversation

@hymkor
Copy link
Copy Markdown
Owner

@hymkor hymkor commented May 11, 2026

  • The test results were previously compared assuming the Japanese timezone, causing failures in other regions.
  • go-ora v2.9.x returns datetime values with UTC timezone information, which also caused the test to fail consistently.
  • The test data itself does not include explicit timezone information.
  • Therefore, comparing timezone strings in the test results was not meaningful and has been removed.
     
  • 日本のタイムゾーンを前提として結果が照合されていたため、他の地域では常に失敗していた。
  • go-ora 2.9 系では、タイムゾーンが UTC になるため、常に失敗していた。
  • テストデータ作成側では、タイムゾーンを記録するようなデータ作成は行っていない。
  • それゆえ、テスト結果の照合でタイムゾーンの比較はあまり意味はないため、除外した。

@hymkor hymkor self-assigned this May 11, 2026
@hymkor hymkor added the bug Something isn't working label May 11, 2026
@hymkor hymkor merged commit 0d6a86b into master May 11, 2026
2 checks passed
@hymkor hymkor deleted the push-zkzpnvpwnssv branch May 11, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant