feat(server,http1,http2,upgrade): remove body static lifetime constraint#4045
Open
Voldemat wants to merge 1 commit intohyperium:masterfrom
Open
feat(server,http1,http2,upgrade): remove body static lifetime constraint#4045Voldemat wants to merge 1 commit intohyperium:masterfrom
Voldemat wants to merge 1 commit intohyperium:masterfrom
Conversation
Before this change, hyper expects body trait implementation to have 'static lifetime, which prevents use cases where one might have StreamBody that references certain state that outlives hyper connection object. This change adds lifetime parameter 'body to varies hyper objects that replaces 'static. This change contains no breaking changes for existing use cases, however it requires appropriate change in hyper-util crate Signed-off-by: Vladimir Voitenko <vladimirdev635@gmail.com>
Author
|
here is link to hyper-util pr with corresponding changes there: hyperium/hyper-util#278 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, hyper expects body trait implementation to have 'static lifetime, which prevents use cases where one might have StreamBody that references certain state that outlives hyper connection object. This change adds lifetime parameter 'body to varies hyper objects that replaces 'static.
This change contains no breaking changes for existing use cases, however it requires appropriate change in hyper-util crate