Limit estimate gas to the current blockLimit#192
Merged
Conversation
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to get into a problematic situation where a transaction is accepted into the EVMConnect transaction queue, with a gas estimation that is higher than the current block limit.
This is because the
eth_estimateGasconfiguration on the node-side does not use the currentgasLimitas the limit on the call. For example in the default Besu configuration, the--rpc-gas-capoption can be unlimited (0) or 100M. Whereas the blockgasLimitis only 4M by default.This PR proposes a best-effort protection on this, when the block tracking mode is full and EVMConnect is monitoring the highest blocks from the blockchain. It tracks the current
gasLimitfrom the head of the chain, and if a transaction gas estimate (after scaling) breaches this limit then an error is thrown.Because the gas estimate occurs before the transaction is accepted, this rejects the transaction with a suitable error early and prevents allocation of a nonce.