feat: increase MAX_MEMORY_SIZE from ~1 GiB to ~16 GiB#1340
Merged
simongdavies merged 1 commit intohyperlight-dev:mainfrom Mar 24, 2026
Merged
feat: increase MAX_MEMORY_SIZE from ~1 GiB to ~16 GiB#1340simongdavies merged 1 commit intohyperlight-dev:mainfrom
simongdavies merged 1 commit intohyperlight-dev:mainfrom
Conversation
The previous limit of 0x4000_0000 - BASE_ADDRESS (~1 GiB) was arbitrary and insufficient for some nanvix related cases. Bump to (16 GiB - BASE_ADDRESS) which is large enough for most use cases while still preventing accidental resource exhaustion. The BASE_ADDRESS subtraction is preserved for consistency with the original definition. Update test to validate the new ~16 GiB boundary. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
added
the
kind/enhancement
simongdavies
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset and
syntactically
as code owners
ludfjig
requested changes
Mar 24, 2026
Contributor
Author
One reason I didn't do this is that I wasnt 100% sure how much memory would actually get allocated if I did this and if it would cause tests to fail on dev machines.. |
Contributor
|
oh yeah maybe this would actually allocate until cow work is complete |
ludfjig
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous limit of 0x4000_0000 - BASE_ADDRESS (~1 GiB) was arbitrary and insufficient for some Nnanvix related cases. Bump to (16 GiB - BASE_ADDRESS) which is large enough for most use cases while still preventing accidental resource exhaustion.
The BASE_ADDRESS subtraction is preserved for consistency with the original definition.
Update test to validate the new ~16 GiB boundary.