fix(rust-ci): pass explicit toolchain: stable to SHA-pinned dtolnay action#439
Merged
Conversation
… action
The reusable Rust CI bundle pins `dtolnay/rust-toolchain` by commit SHA
(`@67ef31d5…`). That action infers the toolchain from its `@`-ref (e.g.
`@stable`), but a SHA ref carries no version, so its "parse toolchain
version" step receives an empty `toolchain` and fails:
'toolchain' is a required input
Process completed with exit code 1
This is the estate-wide `rust-ci / Cargo check + clippy + fmt` red seen
on every PR across the ~28 repos consuming this reusable workflow
(confirmed live in iseriser run 28287559313).
Add `toolchain: stable` to all four `dtolnay/rust-toolchain` steps
(check, test, audit, coverage), matching the `# stable` pin comment.
Consumers inherit the fix on the next standards-reusable pin refresh.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add an explicit
toolchain: stableinput to all fourdtolnay/rust-toolchainsteps in.github/workflows/rust-ci-reusable.yml(thecheck,test,audit, andcoveragejobs).Why
The reusable bundle pins
dtolnay/rust-toolchainby commit SHA (@67ef31d5…). That action infers the toolchain from its@-ref (e.g.@stable→stable), but a SHA ref carries no version, so the action's internal "parse toolchain version" step receives an emptytoolchainand aborts:This is the estate-wide
rust-ci / Cargo check + clippy + fmtred that appears on every PR across the ~28 repos consuming this reusable workflow. Confirmed live againstiseriserrun28287559313(job Cargo check + clippy + fmt), whose failed step logged the env linetoolchain:(empty) immediately before the error.Fix
Each step now passes
toolchain: stable, matching the existing# stablepin comment. Thecheckjob keeps itscomponents: clippy, rustfmt; the other three gain awith:block. No behavioural change beyond making the toolchain explicit — which is exactly what the SHA pin requires.Propagation
Single-source fix: consumers pin this reusable by SHA and inherit the fix on the next standards-reusable pin refresh (the existing "refresh standards reusable pins to current HEAD" flow). No consumer-side edits are part of this PR.
Verification
python3 -c "import yaml; yaml.safe_load(...)"→ YAML parses.dtolnay/rust-toolchainsteps now carrytoolchain: stable(grep-confirmed).🤖 Generated with Claude Code
https://claude.ai/code/session_01A6PSzJWpRxtzGDjUCEh7Mx
Generated by Claude Code