fix: preserve active model across reasoning changes - #18
Merged
Conversation
The agent fix only preserved the agent name; the selected model was still reverting to the default because promptAsync was not receiving the current provider/model pair. Capture the latest model from session messages and pass it through on every reasoning-effort prompt, including temporary resets on session.idle.
Contributor
Author
|
Hi @ian-pascoe - another one from me. Let me know if you want any changes on it. |
Owner
|
@mauriciozaffari Looks good, thank you again! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent fix only preserved the agent name; the selected model was still reverting to the default because
promptAsyncwas not receiving the current provider/model pair. This change captures the latest model from session messages and passes it through on every reasoning-effort prompt, including temporary resets onsession.idle.