feat: support for valid parameters in aws lambda rules#2
Open
uh-zz wants to merge 1 commit into
Open
Conversation
|
I believe this would also solve this issue - dherault/serverless-offline#1677 with serverless-offline - @icarus-sullivan are you able to take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I wanted to support the following signatures from the aws doc, so I added them
Perhaps other signatures are made to respond in the same way
https://docs.aws.amazon.com/lambda/latest/dg/golang-handler.html
Also, the logic is based on the official aws sdk
https://github.com/aws/aws-lambda-go/blob/3afc312542924bc260516dd416c66d43f990390c/lambda/handler.go#L83