Skip to content

Make installed physfs work out-of-the box if it's built with SDL3 support#119

Merged
madebr merged 3 commits into
icculus:mainfrom
madebr:cmake-export-fixes
Jun 16, 2026
Merged

Make installed physfs work out-of-the box if it's built with SDL3 support#119
madebr merged 3 commits into
icculus:mainfrom
madebr:cmake-export-fixes

Conversation

@madebr

@madebr madebr commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator
  • I confirm that I am the author of this code and release it to the PhysicsFS project under the Zlib license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").

@madebr madebr requested a review from sezero June 16, 2026 19:06
@madebr madebr force-pushed the cmake-export-fixes branch from 5359f62 to 81849df Compare June 16, 2026 19:08

@sezero sezero left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is rumored that I'm not good with cmake, and I didn't test this, but if it works with both shared=1+static=0 and shared=0+static=1 combinations in addition to the default of both being 1, then it's OK by me.

@madebr madebr force-pushed the cmake-export-fixes branch from b639b87 to 56c0412 Compare June 16, 2026 19:29
@madebr

madebr commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

It is rumored that I'm not good with cmake, and I didn't test this, but if it works with both shared=1+static=0 and shared=0+static=1 combinations in addition to the default of both being 1, then it's OK by me.

Haha.

I removed linking of SDL3::SDL3 info physfs-static in case people want more control to use a shared/static SDL3 library with physfs. The library won't be out-of-the box anymore and behave like the SDL satellite libraries.

For the satellite libraries, this is a natural behavior because your project is already using SDL3.
With physfs, it's possible to link against a physfs built with SDL3 support, but not use SDL3 yourself.

Then again, this probably does not matter as long as SDL3 support is not enabled by default.

@madebr madebr merged commit c9cc73a into icculus:main Jun 16, 2026
5 checks passed
@madebr madebr deleted the cmake-export-fixes branch June 16, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants