Skip to content

Bump version to 2.8.4#262

Merged
igerber merged 1 commit intomainfrom
release/v2.8.4
Apr 4, 2026
Merged

Bump version to 2.8.4#262
igerber merged 1 commit intomainfrom
release/v2.8.4

Conversation

@igerber
Copy link
Copy Markdown
Owner

@igerber igerber commented Apr 4, 2026

Summary

Methodology references (required if estimator / math changes)

  • N/A — version bump only, no methodology changes in this PR

Validation

  • Tests added/updated: No test changes (version bump only)
  • Backtest / simulation / notebook evidence: N/A

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

Adds CHANGELOG entry covering Survey Phase 8 maturity items: SDR
replicate method (ACS PUMS), FPC for ImputationDiD/TwoStageDiD,
lonely PSU adjust in bootstrap, CV on estimates, weight trimming,
and ImputationDiD pretrends + survey.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Overall Assessment

✅ Looks good

Executive Summary

  • This PR does not modify estimator, weighting, variance, or inference code; methodology review is limited to validating the new release-note text.
  • The methodology-bearing changelog items align with the existing Methodology Registry and code docstrings for SDR, survey-aware pretrends, FPC support, and bootstrap lonely_psu="adjust".
  • The version bump is internally consistent across the Python package, Rust crate, project metadata, and LLM docs surfaces.
  • I found one documentation consistency issue: the new 2.8.4 changelog says several survey features shipped, but the survey tutorial and survey roadmap still describe those same items as unsupported or pending.
  • No P0/P1 correctness, methodology, or security findings in the diff.

Methodology

Code Quality

Performance

  • No findings. No runtime code paths or dependency behavior changed.

Maintainability

  • No findings beyond the documentation consistency item noted below.

Tech Debt

  • No findings. This PR does not introduce new deferred work or untracked correctness debt.

Security

  • No findings. The diff contains no secrets, permission changes, or security-sensitive behavior changes.

Documentation/Tests

  • Severity: P2. Impact: the new release notes say 2.8.4 includes FPC support for ImputationDiD/TwoStageDiD, survey-aware ImputationDiD pretrends, and bootstrap lonely_psu="adjust", but the survey tutorial still marks ImputationDiD and TwoStageDiD as “Partial (no FPC)” and the survey roadmap still describes 8b/8d/8e as pending work. That leaves the release documentation internally contradictory. References: CHANGELOG.md#L10, docs/tutorials/16_survey_did.ipynb#L530, docs/survey-roadmap.md#L229, docs/survey-roadmap.md#L251, docs/survey-roadmap.md#L263. Concrete fix: update the survey compatibility matrix and revise or mark those roadmap items as completed in 2.8.4 so the docs agree on current feature status.
  • No test-blocking finding. For a version-bump-only PR, the absence of new code tests is acceptable.

@igerber igerber merged commit ff63fd5 into main Apr 4, 2026
15 checks passed
@igerber igerber deleted the release/v2.8.4 branch April 4, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant