Skip to content

Patch for mpi compilation on cyfronet Helios#490

Open
Caastlefox wants to merge 1 commit into
igfuw:masterfrom
Caastlefox:test-branch
Open

Patch for mpi compilation on cyfronet Helios#490
Caastlefox wants to merge 1 commit into
igfuw:masterfrom
Caastlefox:test-branch

Conversation

@Caastlefox
Copy link
Copy Markdown

MPI compilation on Cyfronet-Helios environment required two changes
One change to prevent injection of CUDA macros into code by include
#include <boost/numeric/odeint/external/thrust/thrust.hpp>.
In files

libcloudphxx/src/lib_omp.cpp
libcloudphxx/src/lib_cpp.cpp

Second change modifies const into constexpr due to stricter compilation requirements in Cyfronet-Helios environment, where:

dynamic initialization is not supported for a __device__ variable

In C++ standard:
const is a read-only constant
constexpr is a guaranteed compile-time constant

It means static const class despite its name can be initialized dynamically, while __device__ class in Helios environment is required to be initialized statically.

Copy link
Copy Markdown
Author

@Caastlefox Caastlefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since changes in source files turned out to be unnecessary they were removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant