Conversation
Contributor
|
@krlmlr can we close this or is this still necessary? |
Contributor
|
I totally missed this, sorry. I quite like the approach, the |
Contributor
|
Let's see what the builds on the main branch say. |
Contributor
|
Let's see if |
Contributor
|
@copilot: Remove use of the now outlawed |
Agent-Logs-Url: https://github.com/igraph/rigraph/sessions/362ea5b7-1842-4ec3-a9b8-410b04427c01 Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Contributor
Done in 169c104. Replaced all
The sole remaining |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids non-API calls to
Rf_findVar(),Rf_findVarInFrame(), and removes all uses of the now-outlawedR_UnboundValuefrom code compiled on R >= 4.5.0, fixing build failures on R-devel.R_UnboundValueas theifnotfoundsentinel inRx_igraph_get_pointerandRx_igraph_graph_versionis replaced withR_NilValue.identity_func == R_UnboundValueafterRf_findFuninRx_igraph_safe_eval_in_envis removed (Rf_findFunthrows on failure and never returnsR_UnboundValue).R_UnboundValuereference stays inside the#elseblock (R < 4.5.0), which is only compiled on older R where the symbol is available.