Honor use_strict_mode for SessionHandler without validateId - #219
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
iliaal
force-pushed
the
fix/session-strict-validate-fallback
branch
from
August 5, 2026 02:33
ffee250 to
efc4db8
Compare
SessionHandler does not expose validateId(), so strict mode previously fell back to php_session_validate_sid() and accepted unknown IDs. Delegate validation for exact SessionHandler instances to the wrapped module. Keep historical behavior for subclasses, which may implement custom storage.
iliaal
force-pushed
the
fix/session-strict-validate-fallback
branch
from
August 5, 2026 12:00
efc4db8 to
1051b44
Compare
Owner
Author
|
Promoted upstream as php#23071, rebased onto master. Strict-mode validation regressed once before in phpGH-9583, so it takes a full release cycle rather than a patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User save handlers without
validateId()historically accepted every session ID, so strict mode could not reject attacker-chosen IDs for the built-inSessionHandler. ExactSessionHandlerinstances now delegate validation to the wrapped module. Subclasses with custom storage and pure user handlers retain their existing behavior.