Skip to content

Add permanent header-only and compiled library targets with CMake export support#62

Open
grdanny wants to merge 9 commits intoimageworks:masterfrom
grdanny:header_only_separate_target
Open

Add permanent header-only and compiled library targets with CMake export support#62
grdanny wants to merge 9 commits intoimageworks:masterfrom
grdanny:header_only_separate_target

Conversation

@grdanny
Copy link
Copy Markdown
Collaborator

@grdanny grdanny commented Apr 14, 2026

  • replaced the PYSTRING_HEADER_ONLY build option with two permanent targets: pystring::pystring (compiled) and pystring::pystring_header_only (header-only). Consumers pick whichever they need.
  • added exported targets and package config files so downstream projects can consume pystring via find_package(pystring) and link against pystring::pystring or pystring::pystring_header_only.
  • Adjusted CI - making two test executables - pystring_test and pystring_test_header_only run on every CI invocation, verifying both modes work correctly.
  • Added test_header_only_define.cpp which fails the build with #error if PYSTRING_HEADER_ONLY isn't correctly propagated to consumers of the header-only target.
  • revving up release number to 1.2.0 to indicate build system changes.

Assisted-by: Claude / Sonnet 4.6

@grdanny grdanny marked this pull request as ready for review April 14, 2026 19:33
@grdanny grdanny requested a review from lgritz April 14, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant