Refresh packaging metadata and uv-managed dependencies#6
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e30c506fd0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cachetools==5.3.3 | ||
| colorama==0.4.6 | ||
| ec_tools==2.8 | ||
| ec_tools>=3.2 |
There was a problem hiding this comment.
requirements.txt now allows ec_tools>=3.2, but pyproject.toml declares ec-tools>=3.3, so installation paths in this repo produce different dependency floors (notably the README path uses pip install -r requirements.txt). This inconsistency can install an older ec-tools than the project metadata expects and lead to environment-specific runtime/import failures when features from 3.3+ are used.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8cc33cf622
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| python -m pip install --upgrade pip | ||
| python -m pip install flake8 pytest | ||
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi |
There was a problem hiding this comment.
The workflow runs pytest after installing only requirements.txt, but the tests execute ec-enc and ec-vault as shell commands (see test/enc_test.py and test/vault_test.py), which are console scripts provided by this package and are not created unless the project itself is installed. In this CI job, that means the test step will fail with command-not-found errors instead of testing functionality; add a project install step (for example pip install -e . or pip install .) before running tests.
Useful? React with 👍 / 👎.
1 participant
Summary
discovery, and pytest config
scripts
Why
packaging/release configuration for local development and publishing