Add InertiaJS v3 compatibility#193
Closed
gainlinejono wants to merge 9 commits intoinertiaui:mainfrom
Closed
Conversation
Enable compatibility with Inertia v3 and improve request handling. - composer.json: allow inertiajs/inertia-laravel ^3.0. - Support.php: add isInertiaV3() and make isInertiaV2() aware of v3. - ModalServiceProvider.php: when running with Inertia v3, use PropsResolver to resolve props and meta in Response::toArray(). - Modal.php: expand meta keys checked to include Inertia v3 keys (prependProps, deepMergeProps, matchPropsOn, scrollProps, onceProps, sharedProps) while retaining v2 keys. - DispatchBaseUrlRequest.php: copy the original request's session onto the temporary base-url request so middleware that runs before StartSession can access the session without errors. These changes ensure proper prop/meta resolution for Inertia v3 and prevent session-related errors when dispatching internal requests.
|
Any updates on this @pascalbaljet? I'd like to upgrade to InertiaJS 3 but this is blocking me :) |
Co-authored-by: Jayan Ratna <30396013+jayan-blutui@users.noreply.github.com>
Co-authored-by: Jayan Ratna <30396013+jayan-blutui@users.noreply.github.com>
| "@headlessui/react": "^2.1.0", | ||
| "@heroicons/react": "^2.1.4", | ||
| "@inertiajs/react": "^1.3.0||^2.1.11", | ||
| "@inertiajs/react": "^1.3.0||^2.1.11||^3.0.0-beta", |
There was a problem hiding this comment.
Suggested change
| "@inertiajs/react": "^1.3.0||^2.1.11||^3.0.0-beta", | |
| "@inertiajs/react": "^1.3.0||^2.1.11||^3.0.0", |
|
Please release the new version to support Inertia version 3 @pascalbaljet |
|
any update on this? would like to update as well. |
Contributor
|
Thanks for this! I'm closing this one in favor of #201 so we can take full advantage of Inertia 3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable compatibility with inertiajs/inertia-laravel v3, which replaced Response::resolveProperties() and related methods with a standalone PropsResolver class.
Changes
The session fix addresses a separate issue where DispatchBaseUrlRequest creates an internal subrequest that lacks the session store, causing RuntimeException: Session store not set on request.