Skip to content

connector_flow: raise import script exception instead error of failed write #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulius-sladkevicius wants to merge 1 commit into
base: 8.0-connector_flow
Choose a base branch
from
Open

connector_flow: raise import script exception instead error of failed write #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions connector_flow/task/abstract_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
##############################################################################

from openerp.addons.connector.session import ConnectorSession
from openerp import _
import simplejson
from base64 import b64encode, b64decode

from openerp import _
from openerp.addons.connector.session import ConnectorSession


class AbstractTask(object):

Expand Down Expand Up @@ -96,7 +96,10 @@ def run(self, chunk_id=None, **kwargs):
except:
raise
finally:
chunk.write({'state': new_state})
try:
chunk.write({'state': new_state})
except:
pass
Copy link
Copy Markdown

@codingforfun codingforfun Aug 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not correct. If an error occurs during writing the state to the chunk I think the whole transaction will roll back, so it's missleading to silently catch the exeption here.

Copy link
Copy Markdown
Author

@paulius-sladkevicius paulius-sladkevicius Sep 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but now if any error happens in read_chunk(), final error is not what happen there, but error related with failed chunk write. In such case it's hard to understand why read_chunck() failed (found out it while writing unit tests).

return result

def read_chunk(self, **kwargs):
Expand Down