Animate reading time on language swap#99
Draft
injoon5 wants to merge 1 commit into
Draft
Conversation
Wrap the NumberFlow reading-time block in the same displayLang blur transition used for titles and descriptions so the minute count and localized suffix crossfade together when switching languages. Co-authored-by: Injoon Oh <injoon5@icloud.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When switching language on blog and project detail pages, the title, date/description, and body already use the shared
blurTtransition keyed ondisplayLang. The reading-time line only updated viaNumberFlow, so the minute count and suffix (min read/분 읽기) swapped instantly while the rest of the header blurred.This wraps the reading-time
NumberFlowin the same{#each [displayLang]}grid +blurTpattern as the date and description.Test plan
/blog/now-listening)