Remove deprecated ConnectorConfig.log_level field#70
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated top-level ConnectorConfig.log_level configuration option and its deprecation-warning plumbing, consolidating log level configuration under ConnectorConfig.logging.log_level and updating the spec docs accordingly.
Changes:
- Removed
ConnectorConfig.log_leveland thewarn_log_level_deprecated()model validator frominorbit_connector/models.py. - Removed the module-level
warningsimport and DeprecationWarning filter frominorbit_connector/models.py. - Removed the deprecated
log_levelsection from the models specification documentation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| inorbit_connector/models.py | Removes deprecated log_level field + validator and drops module-level deprecation warning configuration. |
| docs/contents/specification/models.md | Deletes the ConnectorConfig.log_level deprecation note from the public spec docs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b-Tomas
force-pushed
the
breaking/remove-deprecated-log-level
branch
from
92c5e23 to
fc22cbd
Compare
miguelgarcia
approved these changes
May 20, 2026
BREAKING CHANGE: `ConnectorConfig.log_level` (deprecated since v1.1.0) is removed. Use `ConnectorConfig.logging.log_level` instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pydantic v2 defaults to extra="ignore", so removing the deprecated log_level field would silently drop it instead of erroring. Setting extra="forbid" ensures stale configs fail loudly. Co-Authored-By: Claude Code <noreply@anthropic.com>
b-Tomas
force-pushed
the
breaking/remove-deprecated-log-level
branch
from
85f2bec to
97d1476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectorConfig.log_levelfield, itswarn_log_level_deprecated()model validator, and the module-levelwarningsimport/filter frommodels.pylog_level" section from the models specification docsBreaking changes
ConnectorConfig.log_levelwas deprecated in v1.1.0 and is now removed. Passinglog_leveldirectly toConnectorConfig(or subclasses) will raise a Pydantic validation error.Migration
LoggingConfig.log_levelis unchanged and remains the canonical way to set the log level.