Remove deprecated robot_id parameter from utils.read_yaml()#72
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated robot_id parameter from inorbit_connector.utils.read_yaml() and updates the related tests and documentation to reflect the simplified configuration-loading behavior.
Changes:
- Removed the
robot_idargument and all deprecation-warning branching logic fromread_yaml(). - Deleted tests that exercised the deprecated
robot_idselection behavior. - Simplified the
read_yamlutility specification docs to match the new API.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/test_utils.py |
Removes tests tied to the deprecated robot_id behavior. |
inorbit_connector/utils.py |
Updates read_yaml() signature and simplifies implementation; drops warnings import. |
docs/contents/specification/utils.md |
Updates the read_yaml specification to remove robot_id behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BREAKING CHANGE: `read_yaml()` no longer accepts a `robot_id` parameter. Callers that used `read_yaml(fname, robot_id)` must load the full dict and index into it themselves, or use `ConnectorConfig` model validation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
03379b8 to
1f6b123
Compare
miguelgarcia
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
robot_idparameter fromread_yaml()inutils.pyand all associated branching logicimport warningsfromutils.py— no longer neededrobot_idbehavior (test_read_yaml_returns_specific_robot,test_read_yaml_raises_error_when_robot_id_not_present)read_yamlspecification indocs/contents/specification/utils.mdBreaking changes
read_yaml()no longer accepts arobot_idparameter. Passing it will raise aTypeError.Migration