Remove command re-exports from inorbit_connector.connector#73
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes (or migrates away from) command-related re-exports previously exposed via inorbit_connector.connector, updating tests, docs, and example connectors to import command utilities from inorbit_connector.commands instead.
Changes:
- Removes backward-compatibility tests and documentation that referenced command re-exports via
inorbit_connector.connector. - Updates usage documentation and example connectors to import
CommandResultCode/CommandFailure(andparse_custom_command_args) frominorbit_connector.commands. - Simplifies
inorbit_connector/connector.pycommand imports by dropping the unusedparse_custom_command_argsimport and removing re-export annotations/comments.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/test_commands.py |
Removes backward-compatibility import tests/aliases for connector re-exports. |
inorbit_connector/connector.py |
Updates command imports and removes the explicit re-export comments/unused import. |
examples/simple-fleet-connector/connector.py |
Imports CommandResultCode from inorbit_connector.commands. |
examples/simple-connector/connector.py |
Imports CommandResultCode from inorbit_connector.commands. |
examples/robot-connector/connector.py |
Imports CommandResultCode from inorbit_connector.commands. |
examples/fleet-connector/connector.py |
Imports CommandResultCode from inorbit_connector.commands. |
docs/contents/usage/single-robot.md |
Updates docs examples to import from inorbit_connector.commands. |
docs/contents/usage/fleet.md |
Updates docs examples to import from inorbit_connector.commands. |
docs/contents/usage/commands-handling.md |
Updates docs examples to consistently import command helpers from inorbit_connector.commands. |
docs/contents/specification/commands.md |
Removes the documentation section describing connector-module re-exports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BREAKING CHANGE: `CommandFailure`, `CommandResultCode`, and `parse_custom_command_args` are no longer re-exported from `inorbit_connector.connector`. Import them from `inorbit_connector.commands` instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ee14045 to
66a12f1
Compare
miguelgarcia
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
# noqa: F401re-export annotations and TODO comment from thecommands import block in
connector.pyparse_custom_command_argsfrom the import (unused inconnector.py);CommandFailureandCommandResultCodestay because they are used internallytest_commands.pydocs/contents/specification/commands.mdcommands-handling.md,fleet.md,single-robot.md) to import frominorbit_connector.commandsCommandResultCodefrominorbit_connector.commandsinstead ofinorbit_connector.connectorBreaking changes
CommandFailure,CommandResultCode, andparse_custom_command_argsare nolonger guaranteed re-exports from
inorbit_connector.connector. Import themfrom
inorbit_connector.commandsinstead.Migration