Skip to content

Remove command re-exports from inorbit_connector.connector#73

Merged
b-Tomas merged 1 commit into
nextfrom
breaking/remove-command-re-exports
May 20, 2026
Merged

Remove command re-exports from inorbit_connector.connector#73
b-Tomas merged 1 commit into
nextfrom
breaking/remove-command-re-exports

Conversation

@b-Tomas
Copy link
Copy Markdown
Member

@b-Tomas b-Tomas commented May 19, 2026

Summary

  • Remove the # noqa: F401 re-export annotations and TODO comment from the
    commands import block in connector.py
  • Remove parse_custom_command_args from the import (unused in connector.py);
    CommandFailure and CommandResultCode stay because they are used internally
  • Remove two backward-compatibility tests and their import aliases from
    test_commands.py
  • Remove the "Note: re-exports" section from docs/contents/specification/commands.md
  • Update all code examples in usage docs (commands-handling.md, fleet.md,
    single-robot.md) to import from inorbit_connector.commands
  • Update four example connectors to import CommandResultCode from
    inorbit_connector.commands instead of inorbit_connector.connector

Breaking changes

CommandFailure, CommandResultCode, and parse_custom_command_args are no
longer guaranteed re-exports from inorbit_connector.connector. Import them
from inorbit_connector.commands instead.

Migration

# Before (v2.x)
from inorbit_connector.connector import (
    CommandResultCode,
    CommandFailure,
    parse_custom_command_args,
)

# After (v3.0)
from inorbit_connector.commands import (
    CommandResultCode,
    CommandFailure,
    parse_custom_command_args,
)

@b-Tomas b-Tomas requested a review from Copilot May 19, 2026 21:11
@b-Tomas b-Tomas self-assigned this May 19, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes (or migrates away from) command-related re-exports previously exposed via inorbit_connector.connector, updating tests, docs, and example connectors to import command utilities from inorbit_connector.commands instead.

Changes:

  • Removes backward-compatibility tests and documentation that referenced command re-exports via inorbit_connector.connector.
  • Updates usage documentation and example connectors to import CommandResultCode/CommandFailure (and parse_custom_command_args) from inorbit_connector.commands.
  • Simplifies inorbit_connector/connector.py command imports by dropping the unused parse_custom_command_args import and removing re-export annotations/comments.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_commands.py Removes backward-compatibility import tests/aliases for connector re-exports.
inorbit_connector/connector.py Updates command imports and removes the explicit re-export comments/unused import.
examples/simple-fleet-connector/connector.py Imports CommandResultCode from inorbit_connector.commands.
examples/simple-connector/connector.py Imports CommandResultCode from inorbit_connector.commands.
examples/robot-connector/connector.py Imports CommandResultCode from inorbit_connector.commands.
examples/fleet-connector/connector.py Imports CommandResultCode from inorbit_connector.commands.
docs/contents/usage/single-robot.md Updates docs examples to import from inorbit_connector.commands.
docs/contents/usage/fleet.md Updates docs examples to import from inorbit_connector.commands.
docs/contents/usage/commands-handling.md Updates docs examples to consistently import command helpers from inorbit_connector.commands.
docs/contents/specification/commands.md Removes the documentation section describing connector-module re-exports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread inorbit_connector/connector.py
@b-Tomas b-Tomas marked this pull request as ready for review May 19, 2026 21:40
@b-Tomas b-Tomas requested a review from miguelgarcia May 19, 2026 23:13
BREAKING CHANGE: `CommandFailure`, `CommandResultCode`, and
`parse_custom_command_args` are no longer re-exported from
`inorbit_connector.connector`. Import them from
`inorbit_connector.commands` instead.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@b-Tomas b-Tomas force-pushed the breaking/remove-command-re-exports branch from ee14045 to 66a12f1 Compare May 19, 2026 23:21
@b-Tomas b-Tomas merged commit 91bf7d6 into next May 20, 2026
13 checks passed
@b-Tomas b-Tomas deleted the breaking/remove-command-re-exports branch May 20, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants