feat(winston): added option to capture info logs#2662
Open
aryamohanan wants to merge 4 commits into
Open
Conversation
aryamohanan
commented
Jul 17, 2026
| silly: LOG_LEVEL.TRACE, | ||
|
|
||
| // RFC 5424 syslog levels | ||
| emerg: LOG_LEVEL.FATAL, |
Contributor
Author
There was a problem hiding this comment.
7 tasks
aryamohanan
force-pushed
the
feat-winston
branch
from
July 17, 2026 05:28
ac11160 to
ad0a413
Compare
aryamohanan
marked this pull request as ready for review
July 17, 2026 05:54
abhilash-sivan
approved these changes
Jul 17, 2026
kirrg001
reviewed
Jul 17, 2026
aryamohanan
commented
Jul 17, 2026
kirrg001
reviewed
Jul 17, 2026
|
|
||
| function levelIsError(level) { | ||
| return level === 'error' || level === 'emerg' || level === 'alert' || level === 'crit'; | ||
| const resolvedLevel = resolveLogLevel(level); |
Contributor
There was a problem hiding this comment.
Currently we call this fn in three places and worst case we call it 3x.
We can remember it:
const normalizedLogLevel = resolveLogLevel(level):
// use it normalizedLogLevel
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for capturing info-level logs for Winston. By default, log capture starts at WARN and above. When configured, INFO logs can also be captured.
Reference: https://github.com/winstonjs/winston#logging-levels
Configuration
The log capture level can be configured using either:
INSTANA_LOG_LEVEL_CAPTUREtracing.logLevelCaptureSupported values:
INFOWARN(default)ERROROFFLog capture behavior
INFOWARNERROROFFref: https://jsw.ibm.com/browse/INSTA-101942
tech spec: https://github.ibm.com/instana/technical-documentation/blob/master/tracing/specification/README.md#log-spans